Skip to content

Conversation

@spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 28, 2018

Proposed changes

Passing the bip38 password by parameter is now deprecated... Instead the forger now reads
the env variables ARK_FORGER_BIP38 and ARK_FORGER_PASSWORD.

See also ArkEcosystemArchive/core-commander#74

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link

codecov-io commented Oct 28, 2018

Codecov Report

Merging #1224 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1224   +/-   ##
========================================
  Coverage    78.55%   78.55%           
========================================
  Files          416      416           
  Lines         6968     6968           
  Branches       925      925           
========================================
  Hits          5474     5474           
  Misses        1319     1319           
  Partials       175      175
Impacted Files Coverage Δ
packages/core/lib/start-forger.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d50a18...6f2f878. Read the comment docs.

@faustbrian faustbrian merged commit fa5adb1 into ArkEcosystem:develop Oct 28, 2018
@ghost ghost removed the review label Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants