Skip to content
This repository was archived by the owner on Mar 5, 2019. It is now read-only.

Conversation

@spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 28, 2018

Proposed changes

The forger parameters bip38 and password are now passed as environment variables.

Before:
screenshot_20181028_013009

After:
screenshot_20181028_012307

Depends on ArkEcosystem/core#1224

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@spkjp spkjp requested a review from faustbrian October 28, 2018 00:17
@faustbrian faustbrian merged commit ee92b54 into ArkEcosystemArchive:master Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants