feat: read bip38 from env (#1224)

Author: spkjp

packages/core-forger/lib/index.js

@@ -11,10 +11,13 @@ exports.plugin = {
   defaults: require('./defaults'),
   alias: 'forger',
   async register (container, options) {
-    const forgerManager = await new ForgerManager(options)
-
+    const forgerManager = new ForgerManager(options)
     const forgers = await forgerManager.loadDelegates(options.bip38, options.password)
 
+    // Don't keep bip38 password in memory
+    delete process.env.ARK_FORGER_PASSWORD
+    delete options.password
+
     container.resolvePlugin('logger').info(`ForgerManager started with ${forgers.length} forgers`)
 
     forgerManager.startForging()

packages/core/lib/start-forger.js

@@ -21,9 +21,9 @@ module.exports = async (options) => {
         networkStart: options.networkStart
       },
       '@arkecosystem/core-forger': {
-        bip38: options.bip38,
+        bip38: options.bip38 || process.env.ARK_FORGER_BIP38,
         address: options.address,
-        password: options.password
+        password: options.password || process.env.ARK_FORGER_PASSWORD
       }
     }
   })