Entities #8
Closed
Entities #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
| } | ||
|
|
||
| pub fn add(self: *ServerEntityManager, entity: main.server.Entity) u32 { | ||
| const id: u32 = @intCast(self.dense.items.len); |
Owner
Author
There was a problem hiding this comment.
Suggested change
| const id: u32 = @intCast(self.dense.items.len); | |
| const sparseId: u32 = @intCast(self.sparse.items.len); |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
Comment on lines
128
to
133
| // The id can only be at most 1 greater then the length of the sparse list. | ||
| if (id == self.sparse.items.len) { | ||
| self.sparse.append(null); | ||
| } | ||
|
|
||
| self.sparse.items[id] = id; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| // The id can only be at most 1 greater then the length of the sparse list. | |
| if (id == self.sparse.items.len) { | |
| self.sparse.append(null); | |
| } | |
| self.sparse.items[id] = id; | |
| self.sparse.append(null); |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
Comment on lines
134
to
135
| self.dense.append(entity); | ||
| self.dense.items[id].id = id; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| self.dense.append(entity); | |
| self.dense.items[id].id = id; | |
| const denseId = self.dense.items.len | |
| self.sparse.items[id] = denseId; | |
| self.dense.append(entity); | |
| self.dense.items[denseId].id = sparseId; |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
| self.dense.append(entity); | ||
| self.dense.items[id].id = id; | ||
|
|
||
| return id; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| return id; | |
| return sparseId; |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
|
|
||
| pub const ServerEntityManager = struct { | ||
| dense: main.List(main.server.Entity), | ||
| sparse: main.List(?u32), |
Owner
Author
There was a problem hiding this comment.
Suggested change
| sparse: main.List(?u32), | |
| sparse: main.List(?u32), | |
| free: main.ListUnmanaged(u32), |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
| pub fn remove(self: *ServerEntityManager, id: u32) void { | ||
| if (!self.contains(id)) return; | ||
|
|
||
| const index = self.sparse.items[id] orelse return; |
Owner
Author
There was a problem hiding this comment.
Suggested change
| const index = self.sparse.items[id] orelse return; | |
| const denseId = self.sparse.items[id] orelse return; |
Argmaster
commented
May 3, 2025
src/entity.zig
Outdated
| return id; | ||
| } | ||
|
|
||
| pub fn remove(self: *ServerEntityManager, id: u32) void { |
Owner
Author
There was a problem hiding this comment.
Suggested change
| pub fn remove(self: *ServerEntityManager, id: u32) void { | |
| pub fn remove(self: *ServerEntityManager, sparseId: u32) void { |
Some funny stuff with entities
Currently Copper beats iron due to its low swing time. This makes iron more elastic, giving it the same swing time as copper. Both a copper-head and an iron-head pickaxe now have a swing time of 0.12s This makes iron strictly better than copper, reducing it from the best metal in the game to a step in the progression, it's still required to mine iron. However the plan is to give it a come-back in the end game due to its high conductivity.
## Description This pull request adds `/replace` command. The main difference from `/set` with `/mask global` is that mask specified for `/replace` is inlined, local and positive, i.e. only blocks matching the mask specified as part of `/replace` command will be affected. `/replace` ignores global masks. ``` /replace <old> <new> ``` `<old>` - expression following mask syntax (PixelGuys#1284), blocks which match will be affected `<new>` - expression following pattern syntax (PixelGuys#1237) used to fill blocks matched by `<old>` ## Examples `/replace cubyz:air cubyz:void` `/replace $leaf|cubyz:air cubyz:stone,cubyz:grass` ## Links Related to: PixelGuys#1214 Depends on: PixelGuys#1337 Depends on: PixelGuys#1284 --------- Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
Resolves: PixelGuys#1457 --------- Co-authored-by: IntegratedQuantum <43880493+IntegratedQuantum@users.noreply.github.com>
… client side (PixelGuys#1475) extracted from PixelGuys#1446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.