Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename ape pm remove to ape pm uninstall #2059

Merged
merged 31 commits into from
May 7, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 6, 2024

What I did

is much more clear - because right now we have install and remove... it should be install and uninstall.

part of project refactor

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@fubuloubu
Copy link
Member

Does this need to be rebased?

@NotPeopling2day
Copy link
Contributor

Does this need to be rebased?

I rebased, but now I'm seeing the conflicts. I'll fix those too.

@antazoey
Copy link
Member Author

antazoey commented May 7, 2024

It good now

@antazoey antazoey merged commit 5c0894b into ApeWorX:feat/08 May 7, 2024
13 checks passed
@antazoey antazoey deleted the refactor/rename-remove branch May 7, 2024 13:33
antazoey added a commit to antazoey/ape that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants