fix!: handle missing size with computed lookup #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Apr 2, 2024
fubuloubu
reviewed
Apr 9, 2024
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
|
@fubuloubu feedback addressed, lemme know |
fubuloubu
previously approved these changes
Apr 9, 2024
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
fubuloubu
approved these changes
Apr 10, 2024
NotPeopling2day
pushed a commit
that referenced
this pull request
Apr 16, 2024
antazoey
added a commit
to antazoey/ape
that referenced
this pull request
Apr 18, 2024
antazoey
added a commit
that referenced
this pull request
Apr 19, 2024
antazoey
added a commit
that referenced
this pull request
Apr 20, 2024
antazoey
added a commit
that referenced
this pull request
Apr 22, 2024
antazoey
added a commit
that referenced
this pull request
Apr 22, 2024
antazoey
added a commit
that referenced
this pull request
Apr 23, 2024
antazoey
added a commit
that referenced
this pull request
Apr 24, 2024
antazoey
added a commit
that referenced
this pull request
Apr 25, 2024
antazoey
added a commit
that referenced
this pull request
Apr 26, 2024
antazoey
added a commit
that referenced
this pull request
Apr 29, 2024
antazoey
added a commit
that referenced
this pull request
Apr 30, 2024
antazoey
added a commit
that referenced
this pull request
May 1, 2024
antazoey
added a commit
that referenced
this pull request
May 1, 2024
antazoey
added a commit
that referenced
this pull request
May 3, 2024
antazoey
added a commit
that referenced
this pull request
May 6, 2024
NotPeopling2day
pushed a commit
to antazoey/ape
that referenced
this pull request
May 7, 2024
antazoey
added a commit
that referenced
this pull request
May 7, 2024
antazoey
added a commit
that referenced
this pull request
May 8, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 9, 2024
antazoey
added a commit
to antazoey/ape
that referenced
this pull request
May 9, 2024
antazoey
added a commit
that referenced
this pull request
May 14, 2024
antazoey
added a commit
that referenced
this pull request
May 14, 2024
antazoey
added a commit
that referenced
this pull request
May 21, 2024
antazoey
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1935
Handles missing block size more gracefully. if it is there, we use it, else we have to look it up. also adds uncles field (would be needed if we had to calculate this thing), also handles a weird case where couldnt init a block from web3 data ( ethereum/web3.py#3326 )
How I did it
How to verify it
Checklist