-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add automine abstract property to TestProviderAPI #1974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't it just raise NotImplementedError for now until 0.8?
It could I guess. Might as well wait though. 0.8 is coming soon, and functionality wise, you can use this feature on the providers that support it (ape-test and ape-foundry) so no one should be blocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for v0.8
Question: does ape-test
provider not support?
It does, it was added here: #1972 |
56a0013
to
3e1eff2
Compare
fixes: #1968
can't merge because this is a breaking change.