Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add automine abstract property to TestProviderAPI #1974

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Mar 28, 2024

fixes: #1968

can't merge because this is a breaking change.

fubuloubu
fubuloubu previously approved these changes Mar 29, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it just raise NotImplementedError for now until 0.8?

@antazoey
Copy link
Member Author

antazoey commented Mar 29, 2024

Can't it just raise NotImplementedError for now until 0.8?

It could I guess. Might as well wait though. 0.8 is coming soon, and functionality wise, you can use this feature on the providers that support it (ape-test and ape-foundry) so no one should be blocked.

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for v0.8

Question: does ape-test provider not support?

@antazoey
Copy link
Member Author

antazoey commented Apr 9, 2024

Question: does ape-test provider not support?

It does, it was added here: #1972

@NotPeopling2day NotPeopling2day changed the base branch from main to feat/08 April 16, 2024 01:11
@antazoey antazoey force-pushed the feat/08 branch 3 times, most recently from 56a0013 to 3e1eff2 Compare April 17, 2024 20:41
@antazoey antazoey merged commit d6ad190 into ApeWorX:feat/08 Apr 17, 2024
13 checks passed
antazoey added a commit to antazoey/ape that referenced this pull request May 9, 2024
@antazoey antazoey deleted the feat/automine branch September 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose automining via TestProviderAPI
2 participants