test: auto mine functionality to eth-tester #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Mar 27, 2024
| assert not eth_tester_provider.auto_mine | ||
|
|
||
| # Ensure can still manually mine. | ||
| block = eth_tester_provider.get_block("latest").number |
There was a problem hiding this comment.
attempted to repro #1969 but mining still seems to work, at least at the provider level.
There was a problem hiding this comment.
not for this feature particularly. if we can get them to upgrade we can see if that helps them else will have to look for more info.
fubuloubu
reviewed
Mar 27, 2024
antazoey
force-pushed
the
fix/automine-ethtester
branch
from
e5c3452
to
e3161de
Compare
fubuloubu
approved these changes
Mar 28, 2024
| assert not eth_tester_provider.auto_mine | ||
|
|
||
| # Ensure can still manually mine. | ||
| block = eth_tester_provider.get_block("latest").number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #1968
How I did it
does the same as https://github.com/ApeWorX/ape-foundry/pull/59/files but for ape-test
thought: maybe need to squeeze this into the api class to keep things uniform, but i implemented the same as ape-foundry's just in case.
How to verify it
connect to ape-test provider which uses eth-tester, and then you can do this
by default, it is on.
Checklist