-
Notifications
You must be signed in to change notification settings - Fork 159
[QC-953] non-critical tasks #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
depends on AliceO2Group/AliceO2#11253 |
Collaborator
Author
|
527ea48 to
5548259
Compare
5548259 to
fac29ce
Compare
Member
|
I just checked this and the topology builds fine now. |
e25b19d to
578be72
Compare
578be72 to
deb886f
Compare
Collaborator
Author
|
After further discussion, we decided that:
|
Collaborator
Author
|
all tests pass now. |
Collaborator
Author
knopers8
reviewed
Dec 18, 2023
Collaborator
Author
|
@knopers8 applied the changes |
knopers8
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.