Post-processing

Author: Barthelemy

Framework/include/QualityControl/PostProcessingConfig.h

@@ -45,6 +45,7 @@ struct PostProcessingConfig {
   std::string consulUrl;
   core::Activity activity;
   bool matchAnyRunNumber = false;
+  bool critical;
 };
 
 } // namespace o2::quality_control::postprocessing

Framework/include/QualityControl/PostProcessingTaskSpec.h

@@ -41,6 +41,7 @@ struct PostProcessingTaskSpec {
   std::string id = "Invalid";
   std::string taskName = "Invalid";
   bool active = true;
+  bool critical = true;
   std::string detectorName = "Invalid";
   boost::property_tree::ptree tree = {};
 };

Framework/postprocessing.json

@@ -42,6 +42,7 @@
     "postprocessing": {
       "ExamplePostprocessing": {
         "active": "true",
+        "critical": "false",     "": "if false the task is allowed to die without stopping the workflow, default: true",
         "className": "o2::quality_control_modules::skeleton::SkeletonPostProcessing",
         "moduleName": "QcSkeleton",
         "detectorName": "TST",

Framework/src/InfrastructureGenerator.cxx

@@ -681,6 +681,10 @@ void InfrastructureGenerator::generatePostProcessing(WorkflowSpec& workflow, con
         ppTask.getOptions()
       };
       dataProcessorSpec.labels.emplace_back(PostProcessingDevice::getLabel());
+      if (!ppTaskSpec.critical) {
+        framework::DataProcessorLabel expendableLabel = { "expendable" };
+        dataProcessorSpec.labels.emplace_back(expendableLabel);
+      }
       dataProcessorSpec.algorithm = adaptFromTask<PostProcessingDevice>(std::move(ppTask));
 
       workflow.emplace_back(std::move(dataProcessorSpec));

Framework/src/InfrastructureSpecReader.cxx

@@ -104,7 +104,7 @@ TaskSpec InfrastructureSpecReader::readSpecEntry<TaskSpec>(const std::string& ta
   }
   ts.dataSource = readSpecEntry<DataSourceSpec>(taskID, taskTree.get_child("dataSource"), wholeTree);
   ts.active = taskTree.get<bool>("active", ts.active);
-  ts.critical = taskTree.get<bool>("critical", ts.active);
+  ts.critical = taskTree.get<bool>("critical", ts.critical);
   ts.maxNumberCycles = taskTree.get<int>("maxNumberCycles", ts.maxNumberCycles);
   ts.resetAfterCycles = taskTree.get<size_t>("resetAfterCycles", ts.resetAfterCycles);
   ts.saveObjectsToFile = taskTree.get<std::string>("saveObjectsToFile", ts.saveObjectsToFile);
@@ -324,6 +324,7 @@ PostProcessingTaskSpec
   ppts.id = ppTaskId;
   ppts.taskName = ppTaskTree.get<std::string>("taskName", ppts.id);
   ppts.active = ppTaskTree.get<bool>("active", ppts.active);
+  ppts.critical = ppTaskTree.get<bool>("critical", ppts.critical);
   ppts.detectorName = ppTaskTree.get<std::string>("detectorName", ppts.detectorName);
   ppts.tree = wholeTree;
 

Framework/src/PostProcessingConfig.cxx

@@ -36,7 +36,8 @@ PostProcessingConfig::PostProcessingConfig(const std::string& id, const boost::p
              config.get<std::string>("qc.config.Activity.provenance", "qc"),
              { config.get<uint64_t>("qc.config.Activity.start", 0),
                config.get<uint64_t>("qc.config.Activity.end", -1) }),
-    matchAnyRunNumber(config.get<bool>("qc.config.postprocessing.matchAnyRunNumber", false))
+    matchAnyRunNumber(config.get<bool>("qc.config.postprocessing.matchAnyRunNumber", false)),
+    critical(true)
 {
   for (const auto& initTrigger : config.get_child("qc.postprocessing." + id + ".initTrigger")) {
     initTriggers.push_back(initTrigger.second.get_value<std::string>());

doc/Advanced.md

@@ -466,22 +466,35 @@ Once a custom class is implemented, one should let QCG know how to display it co
 Some DPL devices can be marked as non-critical. It means that if they die the system will continue running. There is 
 obviously an impact as all the downstream devices won't get data. 
 
-In QC, one can mark a task as critical or non-critical: 
+### QC tasks
 
+In QC, one can mark a task as critical or non-critical:
 ```json
     "tasks": {
       "QcTask": {
         "active": "true",
         "critical": "false",     "": "if false the task is allowed to die without stopping the workflow, default: true",
 ```
-
 By default, they are critical. 
 
+### QC mergers
+
 Mergers are critical or not based on the criticality of the task they are merging data for. 
 
+### QC checkers
+
 Checkers are non-critical. 
 
-Post-processing ???
+### QC post-processing tasks
+
+Post-processing tasks can be marked as critical or non-critical: 
+```json
+    "postprocessing": {
+      "ExamplePostprocessing": {
+        "active": "true",
+        "critical": "false",     "": "if false the task is allowed to die without stopping the workflow, default: true",
+```
+By default, they are critical.
 
 ## QC with DPL Analysis