Skip to content

Conversation

@Barthelemy
Copy link
Collaborator

No description provided.

@Barthelemy Barthelemy requested a review from knopers8 as a code owner November 29, 2023 14:54
@Barthelemy Barthelemy changed the title [QC-953] mergers can receive labels through config [WIP] [QC-953] mergers can receive labels through config Nov 30, 2023
@Barthelemy Barthelemy changed the title [WIP] [QC-953] mergers can receive labels through config [QC-953] mergers can receive labels through config Nov 30, 2023
@Barthelemy
Copy link
Collaborator Author

@knopers8 Could you review when you got a moment ?

@ktf
Copy link
Member

ktf commented Dec 11, 2023

Can we go forward with this? As I understand it block the deployment of the expendable tasks.

@Barthelemy
Copy link
Collaborator Author

@ktf could you have a look and approve ? Piotr is on holidays

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for d52453c at 2023-12-12 10:00:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
/sw/slc8_x86-64/GCC-Toolchain/v12.2.0-alice1-5/include/c++/12.2.0/bits/predefined_ops.h:45:23: error: no match for 'operator<' (operand types are 'o2::framework::DataProcessorLabel' and 'o2::framework::DataProcessorLabel')
/sw/slc8_x86-64/GCC-Toolchain/v12.2.0-alice1-5/include/c++/12.2.0/bits/predefined_ops.h:98:22: error: no match for 'operator<' (operand types are 'o2::framework::DataProcessorLabel' and 'o2::framework::DataProcessorLabel')
/sw/slc8_x86-64/GCC-Toolchain/v12.2.0-alice1-5/include/c++/12.2.0/bits/predefined_ops.h:69:22: error: no match for 'operator<' (operand types are 'o2::framework::DataProcessorLabel' and 'o2::framework::DataProcessorLabel')
ninja: build stopped: subcommand failed.

Full log here.

@Barthelemy Barthelemy requested a review from a team as a code owner December 13, 2023 07:02
@Barthelemy
Copy link
Collaborator Author

Should be good now

@Barthelemy
Copy link
Collaborator Author

@ktf perhaps you could merge it ?

@ktf ktf merged commit 30c25cd into dev Dec 13, 2023
@ktf ktf deleted the add-labels-mergers branch December 13, 2023 18:18
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
andreasmolander pushed a commit to andreasmolander/AliceO2 that referenced this pull request Apr 12, 2024
mwinn2 pushed a commit to mwinn2/AliceO2 that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants