-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Ava to 6 #9081
Draft
turadg
wants to merge
11
commits into
master
Choose a base branch
from
ta/ava-6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
upgrade Ava to 6 #9081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with Cloudflare Pages
|
turadg
force-pushed
the
ta/ava-6
branch
2 times, most recently
from
May 6, 2024 18:50
a8ac83e
to
844cedd
Compare
some packages used `--loader` and some `--import`. The latter no longer works under Ava 6 (or whatever deps upgrading brought in)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9083
Description
Breaking changes in v6: https://github.com/avajs/ava/releases/tag/v6.0.0
This also stops collecting
ava_dur
for Datadog since we don't review that data anymore. Dropping this functionality allows us to stop maintaining the patch that added it.Security Considerations
none, no runtime change
Scaling Considerations
none, no runtime change
Documentation Considerations
none
Testing Considerations
CI
Upgrade Considerations
none, no runtime change