Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Ava to 6 #9081

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

upgrade Ava to 6 #9081

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
31ba542
test(deps): unpatch Ava (forceExit and ava-dur)
turadg Mar 15, 2024
7f81237
chore(deps): bump ava to 6.2.0
turadg Dec 31, 2024
6c97b06
chore(deps): bump @fast-check/ava to 2.0.1
turadg Dec 31, 2024
79a3d7d
chore(deps): bump rimraf
turadg Dec 31, 2024
f4b3fe7
test: don't rely on .serial to be sequential in liquidation-1
turadg Apr 3, 2024
c8ecd1f
test: enable workerThreads
turadg Dec 31, 2024
13b5297
test: Ava 6 compat
turadg Dec 31, 2024
8c039bd
test: '--import' failing
turadg Dec 31, 2024
a2ab680
test: test.failing only for off-spec
turadg Dec 18, 2024
b845010
test: Ava 6 compat
turadg Dec 31, 2024
6de5e1b
chore(deps): downgrade rimraf (v6 droped Node 18)
turadg Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Ava 6 compat
  • Loading branch information
@turadg
turadg committed Dec 31, 2024
commit 13b52976e17b300a12226adc9f47b54922c50424
14 changes: 4 additions & 10 deletions packages/governance/test/unitTests/paramGovernance.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,16 +326,6 @@ test('change multiple params used invitation', async t => {
governorFacets.creatorFacet,
).voteOnParamChanges(installs.counter, 2n, paramChangesSpec);

outcomeOfUpdate
.then(o => t.fail(`update should break, ${o}`))
.catch(e =>
t.regex(
e.message,
/was not a live payment for brand/,
'Invitatation was burned and should not be usable',
),
);

const details = await detailsP;
const positive = details.positions[0];
await setUpVoterAndVote(
Expand All @@ -350,6 +340,10 @@ test('change multiple params used invitation', async t => {
await E(timer).tick();
await E(timer).tick();

await t.throwsAsync(outcomeOfUpdate, {
message: /Invitation passed to paramManager is not live/,
});

// no update2 because the value didn't change

const paramsAfter = await E(publicFacet).getGovernedParams();
Expand Down