test: don't rely on .serial to be sequential in liquidation-1

Agoric · Apr 3, 2024 · fc11f3d · fc11f3d
1 parent 35c42d7
commit fc11f3d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/packages/boot/test/bootstrapTests/test-liquidation-1.ts b/packages/boot/test/bootstrapTests/test-liquidation-1.ts
@@ -140,6 +140,8 @@ const checkFlow1 = async (
     t.fail(error.message);
   });
 
+  await ensureVaultCollateral(collateralBrandKey, t);
+
   const {
     advanceTimeBy,
     advanceTimeTo,
@@ -274,14 +276,12 @@ const checkFlow1 = async (
 
     // TODO express spec up top in a way it can be passed in here
     check.vaultNotification(managerIndex, 0, {
-      debt: undefined,
       vaultState: 'liquidated',
       locked: {
         value: scale6(outcome.vaultsActual[0].locked),
       },
     });
     check.vaultNotification(managerIndex, 1, {
-      debt: undefined,
       vaultState: 'liquidated',
       locked: {
         value: scale6(outcome.vaultsActual[1].locked),
@@ -307,11 +307,6 @@ test.serial(
   {},
 );
 
-test.serial('add STARS collateral', async t => {
-  await ensureVaultCollateral('STARS', t);
-  t.pass(); // reached here without throws
-});
-
 test.serial(
   'liquidate STARS',
   checkFlow1,

diff --git a/packages/boot/tools/liquidation.ts b/packages/boot/tools/liquidation.ts
@@ -207,7 +207,7 @@ export const makeLiquidationTestKit = async ({
       const notification = readLatest(
         `published.vaultFactory.managers.manager${managerIndex}.vaults.vault${vaultIndex}`,
       );
-      t.like(notification, partial);
+      t.like(notification, partial, 'vault notification did not match');
     },
   };