Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to remove anciently outdated Norwegian entries + Removed 6 duplicate entries from foreign.txt. #189406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DandelionSprout
Copy link
Member

Creating the pull request

Please include a summary of the change and which issue is fixed
If the related issue does not exist in our repository, please create it before making pull request
It is highly recommended to use our Web Reporting Tool instead of creating an issue on GitHub directly
Please note, that we verify every pull request manually, so it may take time to apply it

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

#189405

Add your comment and screenshots

If possible, a screenshot of a page or application should not be cropped too much. Otherwise, it is not always clear where the element is located

  1. Your comment

Some entries for Norwegian websites had been outdated for around 5 years each, possibly longer, so I attempted to remove those entries. I also detected 6 other entries that had duplicates within the same file (foreign.txt), so I de-duplicated them accordingly.

(The "Allow edits by maintainers" button for this PR has been turned on, of course.)

  1. Screenshots

All involved factors involve only the PR's file change view below, to the best of my current knowledge. As such, a screenshot would merely be a copy of the file change view.

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

Comment on lines -6127 to -6133
finn.no##iframe#easyad
finn.no##iframe#smallEasyAd
finn.no##.banner-skyscraper-container
finn.no##div.banners[style^="height: 150px"]
finn.no##.banners[data-banner-pos="topbanner"]
finn.no##div.external-banner-board.adsbox[data-controller]
finn.no##.banners.adsbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I don't see finn.no rules in Finnish or your filters.

Copy link
Member Author

@DandelionSprout DandelionSprout Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site received a massive complete overhaul a year or 2 ago, so older entries are simply not needed in any way.

I have finn.no##.banners in Nordic Filters at least, from what I can see. And more than 20 other entries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further clarification: Of the 7 entries that are commented on, only finn.no##.banners.adsbox still matches anything at all, and even then only on the frontpage. The other 6 entries aren't matching any elements at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants