Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anciently outdated Norwegian entries, as well as 6 duplicate entries in foreign.txt #189405

Open
3 tasks done
DandelionSprout opened this issue Sep 24, 2024 · 0 comments
Open
3 tasks done

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Sep 24, 2024

Prerequisites

  • I checked the documentation and found no answer;
  • I checked to make sure that this issue has not already been filed;
  • This is not an ad/bug report.

Problem description

There's some very, very outdated entries in foreign.txt for Norwegian, especially in regards to VG, ITavisen, and FinnNO. Many of the entries have not matched any elements on the sites for more than 5 years, and as such I feel they should be removed.

I also detected 6 entries elsewhere in foreign.txt that had duplicates of them within the same foreign.txt file, which I hope to de-duplicate.

Proposed solution

Remove these entries:

itavisen.no##.banner
finn.no##iframe#easyad
finn.no##iframe#smallEasyAd
finn.no##.banner-skyscraper-container
finn.no##div.banners[style^="height: 150px"]
finn.no##.banners[data-banner-pos="topbanner"]
finn.no##div.external-banner-board.adsbox[data-controller]
finn.no##.banners.adsbox
e24.no##.ad
vg.no##.ad
vg.no##.inline-ad-text
vg.no##.advert
vg.no##.finn-placeholder
itavisen.no##div[id^="ad-"]
vg.no###ad-topboard

Remove duplicates of:

||traffic.styria.hr^
||widget.admiral.hr^
nextech.sk##.promo-zone
jagonews24.com##.featured-inImage-ad-unit
minioppai.org##.kln
well.pl##.sda-container

Additional information

I had noticed "If the related issue does not exist in our repository, please create it before making pull request" in the PR submission form, so I thought, "Hmm, fair enough. I'll create an issue report for it too."

Very loosely inspired by #188315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant