Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempted to remove anciently outdated Norwegian entries + Removed 6 duplicate entries from foreign.txt. #189406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −25
Open

Attempted to remove anciently outdated Norwegian entries + Removed 6 duplicate entries from foreign.txt. #189406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0be072
Attempted to remove anciently outdated Norwegian entries + Removed 6 …
DandelionSprout Sep 24, 2024
4f47319
Corrected 2 entries.
DandelionSprout Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions BaseFilter/sections/foreign.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,8 +1174,6 @@ jockantv.com###Toast1
jockantv.com###Dialog1
jockantv.com#%#//scriptlet('prevent-window-open')
! https://github.com/AdguardTeam/AdguardFilters/issues/149285
||traffic.styria.hr^
||widget.admiral.hr^
vecernji.hr##.single-article__row--top-offer
! https://github.com/AdguardTeam/AdguardFilters/issues/149276
rezultati.com##.detailLeaderboard
Expand Down Expand Up @@ -1397,7 +1395,6 @@ nextech.sk##.promo-zone
||nextech.sk/files/photo/*left.jpg
||nextech.sk/files/photo/*right.jpg
nextech.sk##a[href^="https://www.canon.sk/offers/"]
nextech.sk##.promo-zone
! https://github.com/AdguardTeam/AdguardFilters/issues/165598
nikee.net#?#td > div[style*="width:"]:has(> div[style]:contains(/Reklama|AONN.cz/))
||alza.cz^$domain=nikee.net
Expand Down Expand Up @@ -3491,7 +3488,6 @@ bb.is$$div[class="banner"]
||jamuna.tv/ad/
! https://github.com/AdguardTeam/AdguardFilters/issues/185130
jagonews24.com##div.text-center:has(> div[id^="div-gpt-ad-"])
jagonews24.com##.featured-inImage-ad-unit
! https://github.com/AdguardTeam/AdguardFilters/issues/182968
nagpurtoday.in##aside[id^="custom_html-"][class*="widget"]:has(img + .popup)
nagpurtoday.in###header-sidebar
Expand Down Expand Up @@ -3839,7 +3835,6 @@ nontonhentai.top##.extend
doujindesu.tv#?#center:has(> a[target="_blank"] > img)
! https://github.com/AdguardTeam/AdguardFilters/issues/172425
minioppai.org###btm_banner
minioppai.org##.kln
! https://github.com/AdguardTeam/AdguardFilters/issues/172298
ggwp.id##.sticky-footer
ggwp.id##a[href^="https://www.threads.net/"]
Expand Down Expand Up @@ -6121,28 +6116,13 @@ tu.no##.col-full-width > .products-carousel.daily-offers
! https://github.com/AdguardTeam/AdguardFilters/issues/21961
||nakenprat.com/adfirst*.js
||nakenprat.com/adlast*.php^
! https://github.com/AdguardTeam/AdguardFilters/issues/20808
itavisen.no##.banner
! https://github.com/AdguardTeam/AdguardFilters/issues/16687
finn.no##iframe#easyad
finn.no##iframe#smallEasyAd
finn.no##.banner-skyscraper-container
finn.no##div.banners[style^="height: 150px"]
finn.no##.banners[data-banner-pos="topbanner"]
finn.no##div.external-banner-board.adsbox[data-controller]
finn.no##.banners.adsbox
Comment on lines -6127 to -6133
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I don't see finn.no rules in Finnish or your filters.

Copy link
Member Author

@DandelionSprout DandelionSprout Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site received a massive complete overhaul a year or 2 ago, so older entries are simply not needed in any way.

I have finn.no##.banners in Nordic Filters at least, from what I can see. And more than 20 other entries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further clarification: Of the 7 entries that are commented on, only finn.no##.banners.adsbox still matches anything at all, and even then only on the frontpage. The other 6 entries aren't matching any elements at all.

! https://github.com/AdguardTeam/AdguardFilters/issues/11958
@@||advert.vg.no/1v*.js?v=$domain=e24.no
@@||advertisement.vg.no/1v*.js?v=$domain=e24.no
e24.no#%#//scriptlet("set-constant", "__AB__", "noopFunc")
e24.no##.ad
! https://github.com/AdguardTeam/AdguardFilters/issues/10383
@@||advert.vg.no/1v*.js?v=$~third-party
@@||advertisement.vg.no/1v*.js?v=$~third-party
vg.no##.ad
vg.no##.inline-ad-text
vg.no##.advert
vg.no##.finn-placeholder
!+ PLATFORM(windows, mac, android)
||no-vg.videoplaza.tv/proxy/distributor/$domain=vgtv.no|vg.no,important
! https://github.com/AdguardTeam/AdguardFilters/issues/7960
Expand All @@ -6153,9 +6133,6 @@ tv2.no##.tv2-ad
||tv2.no/s/misc/homad/homadConfigTV2Live.json$replace=/"enabled":\strue\,/"enabled": false\,/i
! https://github.com/AdguardTeam/AdguardFilters/issues/6064
vgtv.no###player.pulse-isPauseAdVisible > .jw-overlays
!
itavisen.no##div[id^="ad-"]
vg.no###ad-topboard
!---------------------------------------------------------------------
!------------------------------ Persian ------------------------------
!---------------------------------------------------------------------
Expand Down Expand Up @@ -6434,6 +6411,7 @@ itbiznes.pl###main > div.code-block > a[target="_blank"] > img
olsztynnews.com.pl##.a-wrap
! https://github.com/AdguardTeam/AdguardFilters/issues/178160
radiojura.pl##.sec-promo
! https://github.com/AdguardTeam/AdguardFilters/issues/119676
! https://github.com/AdguardTeam/AdguardFilters/issues/178162
well.pl##.sda-container
well.pl##.partners-box
Expand Down Expand Up @@ -7605,8 +7583,6 @@ xgp.pl###hdrbnr
xgp.pl##div[id^="xgppl-"] > a[target="_blank"] > img
xgp.pl##div[class^="adslot_"]
xgp.pl##.entry-content > div[class$="-target"][style^="margin-left: auto; margin-right: auto; text-align: center;"]
! https://github.com/AdguardTeam/AdguardFilters/issues/119676
well.pl##.sda-container
! https://github.com/AdguardTeam/AdguardFilters/issues/119489
donald.pl##ins[class^="staticpubads"]
! https://github.com/AdguardTeam/AdguardFilters/issues/119486
Expand Down