Skip to content

Release v1.8.0 #3536

Merged
jason-aelf merged 26 commits intomasterfrom
release/1.8.0
Mar 28, 2024
Merged

Release v1.8.0 #3536
jason-aelf merged 26 commits intomasterfrom
release/1.8.0

Conversation

@louis4li
Copy link
Collaborator

Closes #3535

louis4li and others added 25 commits February 22, 2024 15:39
…restriction

feat:remove nft decimal restriction
…d-chain' into feature/create-token-on-specified-chain
…cified-chain

Create token on specified chain
…te-token-on-specified-chain

# Conflicts:
#	contract/AElf.Contracts.MultiToken/TokenContractConstants.cs
…cified-chain

Enhance compatibility with historical NFT creation
@vizipi
Copy link

vizipi bot commented Mar 28, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 264 9
100.00% jason-hoopox 23 9
100.00% gldeng 19 9
100.00% ZhangXin 15 9
100.00% zhifenglee-portkey 6 9
88.89% kaiwenzhengaelf 37 8

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
contract/AElf.Contracts.MultiToken/TokenContract_Fees.cs80.00%4 out of 5 times
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs80.00%4 out of 5 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT80.00%4 out of 5 times
...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe80.00%4 out of 5 times
...contract/AElf.Contracts.Election/ElectionContract_Elector80.00%4 out of 5 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs80.00%4 out of 5 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio80.00%4 out of 5 times
contract/AElf.Contracts.Profit/ProfitContract.cs80.00%4 out of 5 times
...test/AElf.Contracts.EconomicSystem.Tests/BVT/TreasuryBasi80.00%4 out of 5 times
...test/AElf.Contracts.TokenConverter.Tests/TokenConverterCo80.00%4 out of 5 times

Committed file ranks

(click to expand)
  • 94.19%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • 98.96%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 96.84%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 99.43%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 98.24%[...contract/AElf.Contracts.MultiToken/TokenContractConstants]
  • 99.97%[protobuf/token_contract.proto]
  • 97.67%[protobuf/token_contract_impl.proto]
  • 89.21%[...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe]
  • @vizipi vizipi bot requested review from arg-foo, gldeng, jason-aelf and zhxymh March 28, 2024 07:06
    @vizipi vizipi bot requested a review from kaiwenzhengaelf March 28, 2024 07:07
    @jason-aelf jason-aelf changed the title Release/1.8.0 Release v1.8.0 Mar 28, 2024
    @codecov
    Copy link

    codecov bot commented Mar 28, 2024

    Codecov Report

    Attention: Patch coverage is 94.54545% with 3 lines in your changes are missing coverage. Please review.

    Project coverage is 90.70%. Comparing base (2d30519) to head (88e0c3c).

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##           master    #3536   +/-   ##
    =======================================
      Coverage   90.69%   90.70%           
    =======================================
      Files         663      663           
      Lines       25500    25543   +43     
      Branches     2287     2293    +6     
    =======================================
    + Hits        23128    23168   +40     
    - Misses       2256     2259    +3     
      Partials      116      116           
    Files Coverage Δ
    ...lf.Contracts.MultiToken/TokenContract_NFTHelper.cs 100.00% <ø> (ø)
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 95.84% <97.50%> (+0.09%) ⬆️
    ....Contracts.MultiToken/TokenContract_NFT_Actions.cs 89.28% <86.66%> (-1.13%) ⬇️

    @jason-aelf jason-aelf merged commit 1842512 into master Mar 28, 2024
    David20240718 pushed a commit that referenced this pull request Jun 21, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants