Skip to content

Create token on specified chain#3531

Merged
jason-aelf merged 7 commits intorelease/1.8.0from
feature/create-token-on-specified-chain
Mar 3, 2024
Merged

Create token on specified chain#3531
jason-aelf merged 7 commits intorelease/1.8.0from
feature/create-token-on-specified-chain

Conversation

@louis4li
Copy link
Collaborator

@louis4li louis4li commented Mar 1, 2024

Closes #3529

@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.69%. Comparing base (109e92f) to head (4787599).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/1.8.0    #3531      +/-   ##
=================================================
- Coverage          90.69%   90.69%   -0.01%     
=================================================
  Files                663      663              
  Lines              25495    25498       +3     
  Branches            2287     2289       +2     
=================================================
+ Hits               23123    23125       +2     
- Misses              2256     2257       +1     
  Partials             116      116              
Files Coverage Δ
...AElf.Contracts.MultiToken/TokenContract_Actions.cs 95.75% <100.00%> (+<0.01%) ⬆️
....Contracts.MultiToken/TokenContract_NFT_Actions.cs 89.04% <66.66%> (-1.10%) ⬇️

@vizipi
Copy link

vizipi bot commented Mar 1, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 181 4
100.00% kaiwenzhengaelf 25 4
100.00% jason-hoopox 14 4
100.00% ZhangXin 10 4
100.00% zhifenglee-portkey 5 4
100.00% gldeng 4 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT83.33%15 out of 18 times
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs77.78%14 out of 18 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio66.67%12 out of 18 times
protobuf/token_contract.proto61.11%11 out of 18 times
...contract/AElf.Contracts.MultiToken/TokenContractConstants61.11%11 out of 18 times
test/AElf.Contracts.TestContract.DApp/DAppContract.cs50.00%9 out of 18 times

Committed file ranks

(click to expand)
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 96.53%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 93.70%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • 98.90%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • @jason-aelf jason-aelf changed the title create token on specified chain Create token on specified chain Mar 1, 2024
    @vizipi vizipi bot requested a review from jason-aelf March 2, 2024 07:16
    @jason-aelf jason-aelf merged commit 664382e into release/1.8.0 Mar 3, 2024
    @delete-merged-branch delete-merged-branch bot deleted the feature/create-token-on-specified-chain branch March 3, 2024 06:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants