Skip to content

Token contract support batch approve#3532

Merged
jason-aelf merged 9 commits intorelease/1.8.0from
feature/batch-approve
Mar 3, 2024
Merged

Token contract support batch approve#3532
jason-aelf merged 9 commits intorelease/1.8.0from
feature/batch-approve

Conversation

@louis4li
Copy link
Collaborator

@louis4li louis4li commented Mar 1, 2024

@vizipi
Copy link

vizipi bot commented Mar 1, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 264 6
100.00% kaiwenzhengaelf 36 6
100.00% jason-hoopox 23 6
100.00% gldeng 19 6
100.00% ZhangXin 15 6
100.00% zhifenglee-portkey 2 6

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...test/AElf.Contracts.MultiToken.Tests/MultiTokenContractTe87.50%14 out of 16 times
...contract/AElf.Contracts.Election/ElectionContract_Elector87.50%14 out of 16 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio87.50%14 out of 16 times
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs81.25%13 out of 16 times
contract/AElf.Contracts.Economic/EconomicContract.cs81.25%13 out of 16 times
test/AElf.Contracts.TestBase/ContractTester.cs81.25%13 out of 16 times
contract/AElf.Contracts.Profit/ProfitContract.cs81.25%13 out of 16 times
...contract/AElf.Contracts.CrossChain/CrossChainContract_Hel75.00%12 out of 16 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT75.00%12 out of 16 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs75.00%12 out of 16 times

Committed file ranks

(click to expand)
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 98.93%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 99.41%[contract/AElf.Contracts.MultiToken/TokenContractState.cs]
  • 98.13%[...contract/AElf.Contracts.MultiToken/TokenContractConstants]
  • 99.97%[protobuf/token_contract.proto]
  • 97.60%[protobuf/token_contract_impl.proto]
  • @codecov
    Copy link

    codecov bot commented Mar 1, 2024

    Codecov Report

    Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

    Project coverage is 90.70%. Comparing base (664382e) to head (4f7f563).

    Additional details and impacted files

    Impacted file tree graph

    @@              Coverage Diff               @@
    ##           release/1.8.0    #3532   +/-   ##
    ==============================================
      Coverage          90.69%   90.70%           
    ==============================================
      Files                663      663           
      Lines              25498    25532   +34     
      Branches            2289     2293    +4     
    ==============================================
    + Hits               23125    23158   +33     
    - Misses              2257     2258    +1     
      Partials             116      116           
    Files Coverage Δ
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 95.84% <97.36%> (+0.08%) ⬆️

    @jason-aelf jason-aelf changed the title token batch approve Token contract support batch approve Mar 1, 2024
    @jason-aelf jason-aelf merged commit 7dbd094 into release/1.8.0 Mar 3, 2024
    @delete-merged-branch delete-merged-branch bot deleted the feature/batch-approve branch March 3, 2024 10:09
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants