Dev --> master #2373
Merged
Dev --> master #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new related_posts plugin * clean up * remove related_posts_spec * hound * hound
houndci-bot
reviewed
Mar 24, 2017
| # Only the main Sass file needs front matter (the dashes are enough) | ||
| --- | ||
|
|
||
| @import "_print/all"; |
There was a problem hiding this comment.
Invalid CSS after "...rt "_print/all"": expected "{", was ";"
| } | ||
|
|
||
| .card-link-tagline > * { | ||
| margin: 0 !important; |
|
|
||
| .list-images, | ||
| .list-images-item { | ||
| display: block !important; |
| } | ||
|
|
||
| .list-columns .usa-width-one-third { | ||
| width: 100% !important; |
| -moz-box-shadow: none !important; | ||
| -ms-box-shadow: none !important; | ||
| -o-box-shadow: none !important; | ||
| box-shadow: none !important; |
| @@ -0,0 +1,36 @@ | |||
| .card-image-bg { | |||
| display: none !important; | |||
| margin: 0 !important; | ||
|
|
||
| img { | ||
| display: none !important; |
| @@ -0,0 +1,8 @@ | |||
| .graphic-list-link { | |||
| margin: 0 !important; | |||
| @@ -0,0 +1,3 @@ | |||
| .section-newsletter { | |||
| display: none !important; | |||
| @@ -0,0 +1,3 @@ | |||
| .blog-search { | |||
| display: none !important; | |||
* blockquotes * moved nav styles to own scss file, still need work especially moblie * Update order of headings, adjusted colors and background * nav redux * new layout, persistent header and nav * broken on to other pages * wrote introduction, switched order of code, documentation * cleaned up colors * clearing a hound check * improve docs * started adding images * sticky nav * more work on images * naming * document usage of Jekyll throughout the site * rspec * docs * added blog images and captions section. Need to add documentation * added image documentation * hero image code * right aligned attribute page and code * blog images * added breadcrumb, expanded images to blog images * call to action wording * hide debugging * typo * rearrange navigation * oembed * Added documentation to right aligned list * Additional documentation to breadcrumb section * removed commented out js
houndci-bot
reviewed
Mar 27, 2017
| site.config['n_cores'] ? site.config['n_cores'] : 1 | ||
| end | ||
|
|
||
| def generate(site) |
There was a problem hiding this comment.
Assignment Branch Condition size for generate is too high. [19.21/15]
| @use_categories = false | ||
| @use_categories = true if site.config['related_categories'] | ||
| @use_tags = false if !site.config['related_tags'].nil? && site.config['related_tags'] != true | ||
| @use_authors = false if !site.config['related_authors'].nil? && site.config['related_authors'] != true |
| end.collect { |post, _freq| post } | ||
| end | ||
|
|
||
| def create_presets(site) |
There was a problem hiding this comment.
Assignment Branch Condition size for create_presets is too high. [17.8/15]
| else | ||
| b[0].date <=> a[0].date | ||
| end | ||
| end.collect { |post, _freq| post } |
There was a problem hiding this comment.
Avoid multi-line chains of blocks.
| related_posts = '<p>No related posts</p>' | ||
| # Calculate the frequency of each tag. | ||
| # Returns {tag => freq, tag => freq, ...} | ||
| def tag_freq(posts) |
There was a problem hiding this comment.
Assignment Branch Condition size for tag_freq is too high. [15.81/15]
| end | ||
| # Calculate related posts. | ||
| # Returns [<Post>] | ||
| def related_posts(me, posts) |
There was a problem hiding this comment.
Assignment Branch Condition size for related_posts is too high. [43.91/15]
Cyclomatic complexity for related_posts is too high. [11/6]
Method has too many lines. [29/10]
Perceived complexity for related_posts is too high. [11/7]
|
|
||
| var $anchors = $(anchors.join(',')); |
Update frontmatter tests
This updates the documentation in the README so that users have an easier time finding the style guide. cc
Update Readme to better link to styleguide
* delete unused pages * simplify subnavigation to eliminate 'children ' option * remove unnecessary plugins * simplified configuration * remove debugs * add introduction section to styleguide * rspec
houndci-bot
reviewed
Mar 30, 2017
|
|
||
| .usa-grid.content-focus { | ||
| padding-left: 0 !important; | ||
| padding-right: 0 !important; |
| } | ||
|
|
||
| .usa-grid.content-focus { | ||
| padding-left: 0 !important; |
| } | ||
|
|
||
| a::after { | ||
| font-size: 1rem !important; |
| } | ||
|
|
||
| img { | ||
| max-width: 500px !important; |
| .menu-btn, | ||
| .link-arrow-right svg, | ||
| .link-arrow-left svg { | ||
| display: none !important; |
* address width * added layout section * subpages * nav children * long pages * remove old sections * order
houndci-bot
reviewed
Mar 30, 2017
| page_url = clip_char(page_url.to_s.downcase, '/').split('/')[0] | ||
| u = clip_char(u.to_s.downcase, '/').split('/')[0] | ||
| # if the url group is 'blog', match date strings | ||
| is_blog_post = (u == 'blog') && (page_url.to_i.positive?) |
There was a problem hiding this comment.
Don't use parentheses around a method call.
Sync vulnerability policy / add login.gov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 PREVIEW
Preview README for this branch
Changes proposed in this pull request:
/cc @gboone @elainekamlley