Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style guide 3.0 #2380

Merged
merged 7 commits into from
Mar 30, 2017
Merged

Style guide 3.0 #2380

merged 7 commits into from
Mar 30, 2017

Conversation

gemfarmer
Copy link
Contributor

@gemfarmer gemfarmer commented Mar 30, 2017 •
edited
Loading

Fixes issue(s) #2370 (comment)

CircleCI

😎 PREVIEW

Preview README for this branch

Changes proposed in this pull request:

  • Response @jenniferthibault's critique
    • creates child sections in the navigation
    • Splits child pages on to one page
    • Adds introduction tab to navigation
    • Fixes other, smaller bugs
  • Fixes small bug in project cards template

/cc @elainekamlley @jenniferthibault

elainekamlley
elainekamlley approved these changes Mar 30, 2017
View reviewed changes
Copy link
Contributor

@elainekamlley elainekamlley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gemfarmer gemfarmer merged commit 44b6eba into dev Mar 30, 2017
@gemfarmer gemfarmer deleted the sg-3 branch March 30, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elainekamlley elainekamlley elainekamlley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemfarmer @elainekamlley