Styleguide 2.0 #2365
Styleguide 2.0 #2365
Conversation
_sass/_styleguide/nav.scss
Outdated
| } | ||
|
|
||
| .sliding-panel-close-styleguide { | ||
| @include media($medium-screen + $nav-width-extra) { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
_sass/_styleguide/nav.scss
Outdated
| height: $icon-diameter; | ||
| width: $icon-diameter; | ||
|
|
||
| path { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
_sass/_core/variables.scss
Outdated
| @@ -27,6 +27,8 @@ $color-bright: #00cfff; // $color-bright / $color-secondary | |||
| $color-medium: #046b99; // $color-medium / $color-primary | |||
| $color-dark: #1C304A; // $color-dark / $color-primary-dark | |||
| $color-base: #1F2E4A; | |||
| $color-black: #000000; | |||
assets/js/index.js
Outdated
| @@ -7,8 +7,11 @@ $(function (){ | |||
|
|
|||
| // Styleguide drawer | |||
| $('.menu-btn-styleguide, .sliding-panel-close-styleguide').on('click touchstart', function (e) { | |||
| console.log('click', $('.nav-mobile-styleguide').hasClass('is-visible')) | |||
There was a problem hiding this comment.
Unexpected console statement no-console
'$' is not defined no-undef
…nto styleguide-2.0
|
@gemfarmer when I try the preview link, every time I click an item from the side menu I get one of these:
Am I missing a step? |
assets/js/index.js
Outdated
|
|
||
| var $anchors = $(anchors.join(',')); |
assets/js/index.js
Outdated
| @@ -26,8 +27,11 @@ $(function (){ | |||
| .replace(window.location.pathname, ''); | |||
| }); | |||
|
|
|||
| var $anchors = $(anchors.join(',')); | |||
| anchors = anchors.filter(function(anchor) { | |||
| return anchor[0] == '#'; | |||
There was a problem hiding this comment.
Expected '===' and instead saw '==' eqeqeq
| @@ -80,17 +80,17 @@ def frontmatter_regex | |||
| /\A(---\s*\n.*?\n?)^((---|\.\.\.)\s*$\n?)/m | |||
| end | |||
|
|
|||
| def find_penned_authors | |||
| penned_authors = [] | |||
| def find_published_authors | |||
There was a problem hiding this comment.
Assignment Branch Condition size for find_published_authors is too high. [16.76/15]
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| module SiteData | |||
| class AuthorData | |||
| attr_reader :path, :basepath, :penned_authors, :site_post_paths, :all_authors, :excluded_authors | |||
| attr_reader :path, :basepath, :published_authors, :site_post_paths, :all_authors, :unpublished_authors | |||
|
@jenniferthibault You weren't missing anything! The links were broken on Federalist. They should be fixed now though! |
_sass/_styleguide/all.scss
Outdated
| } | ||
| @import 'nav'; | ||
| @import 'sticky'; | ||
| @import 'right-aligned-list' |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
_sass/_styleguide/all.scss
Outdated
| } | ||
| @import 'nav'; | ||
| @import 'sticky'; | ||
| @import 'right-aligned-list' |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
_plugins/utility.rb
Outdated
| puts '---------------------' | ||
| puts "#{value} is a #{_type}" | ||
| puts '---------------------' | ||
| binding.pry |
There was a problem hiding this comment.
Remove debugger entry point binding.pry.
|
@jenniferthibault @gboone @awfrancisco Looking for feedback on the latest style guide improvements! |
|
Merging and closing this issue, but we are going to keep #2242 open for additional comments and criticism! |
|
|
||
| var $anchors = $(anchors.join(',')); |
Fixes issue(s) #2242
😎 PREVIEW
Preview README for this branch
Changes proposed in this pull request:
/cc @elainekamlley