Hotfix/v0.1.3 by tclemos · Pull Request #2173 · 0xPolygon/zkevm-node

tclemos · 2023-06-08T15:43:58Z

Closes #2124
Closes #2172
Closes #2168
Closes #2160
Closes #2212

What does this PR do?

Fix web sockets concurrency writes error
Fix eth_syncing to return false when node is synchronized
Fix custom tracer to handle internal tx errors when a context is not created.
Makes max grpc message size configurable.

New Config Parameter:

[Executor]
MaxGRPCMessageSize = 100000000

Reviewers

Main reviewers:

@ToniRamirezM
@agnusmor

…s used

ARR552 · 2023-06-09T06:16:06Z

test/contracts/auto/OpCallAux.sol

+    // function opDelegateCallSelfBalance(
+    //     address addrCall
+    // ) external payable returns (uint256) {
+    //     addrCall.call{value: msg.value}(
+    //         abi.encodeWithSignature("opDelegateCallSelfBalance()")
+    //     );
+    //     assembly {
+    //         let val := address()
+    //         sstore(0x3, val)
+    //         let val2 := codesize()
+    //         sstore(0x4, val2)
+    //         let val3 := msize()
+    //         codecopy(val3, 0x0, val2)
+    //         let val4 := mload(val3)
+    //         sstore(0x5, val3)
+    //     }
+    // }
+
+    // function opDelegateDelegateSelfBalance(
+    //     address addrCall
+    // ) external payable returns (uint256) {
+    //     addrCall.delegatecall(
+    //         abi.encodeWithSignature("opDelegateCallSelfBalance()")
+    //     );
+    //     assembly {
+    //         let val := address()
+    //         sstore(0x3, val)
+    //         let val2 := codesize()
+    //         sstore(0x4, val2)
+    //         let val3 := msize()
+    //         codecopy(val3, 0x0, val2)
+    //         let val4 := mload(val3)
+    //         sstore(0x5, val3)
+    //     }


Why do we need to keep this commented code?

* make max grpc message size configurable * fix state tests * fix tests * fix tests

Get SequencerNodeURI from SC

* optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize

Fix load zkCounters from pool

…2213)

This reverts commit 860f0e7.

Fix GetWIPBatch when previous last batch is a forced batch

Hotfix/forced batch

* Fix BatchL2Data * Force GHA

* fix concurrent web socket writes * fix eth_syncing * fix custom trace internal tx call error handling and update prover * add test to custom tracer depth issue; fix internal call error and gas used * fix custom tracer for internal tx with error and no more steps after it * remove debug code * Make max grpc message size configurable (#2179) * make max grpc message size configurable * fix state tests * fix tests * fix tests * get SequencerNodeURI from SC if empty and not IsTrustedSequencer * Optimize trace (#2183) * optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize * move log for the best fitting tx (#2192) * fix load zkCounters from pool * remove unnecessary log.info * add custom tracer support to CREATES opcode without depth increase (#2213) * logs * fix getting stateroot from previous batch (GetWIPBatch) * logs * Fix GetWipBatch when previous last batch is a forced batch * fix forcedBatch trusted state * Revert "fix getting stateroot from previous batch (GetWIPBatch)" This reverts commit 860f0e7. * force GHA * add pool limits (#2189) * Hotfix/batch l2 data (#2223) * Fix BatchL2Data * Force GHA --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: agnusmor <agnusmor@gmail.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Alonso <ARR551@protonmail.com> Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com>

* Hotfix/v0.1.3 (#2173) * fix concurrent web socket writes * fix eth_syncing * fix custom trace internal tx call error handling and update prover * add test to custom tracer depth issue; fix internal call error and gas used * fix custom tracer for internal tx with error and no more steps after it * remove debug code * Make max grpc message size configurable (#2179) * make max grpc message size configurable * fix state tests * fix tests * fix tests * get SequencerNodeURI from SC if empty and not IsTrustedSequencer * Optimize trace (#2183) * optimize trace * fix memory reading * update docker image * update prover image * fix converter * fix memory * fix step memory * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * fix structlogs * update prover image * fix struclogs * fix memory size * fix memory size * fix memory size * refactor memory resize * refactor memory resize * move log for the best fitting tx (#2192) * fix load zkCounters from pool * remove unnecessary log.info * add custom tracer support to CREATES opcode without depth increase (#2213) * logs * fix getting stateroot from previous batch (GetWIPBatch) * logs * Fix GetWipBatch when previous last batch is a forced batch * fix forcedBatch trusted state * Revert "fix getting stateroot from previous batch (GetWIPBatch)" This reverts commit 860f0e7. * force GHA * add pool limits (#2189) * Hotfix/batch l2 data (#2223) * Fix BatchL2Data * Force GHA --------- Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com> Co-authored-by: agnusmor <agnusmor@gmail.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Alonso <ARR551@protonmail.com> Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com> * fix test --------- Co-authored-by: Thiago Coimbra Lemos <tclemos@users.noreply.github.com> Co-authored-by: agnusmor <agnusmor@gmail.com> Co-authored-by: agnusmor <100322135+agnusmor@users.noreply.github.com> Co-authored-by: Alonso <ARR551@protonmail.com> Co-authored-by: Alonso Rodriguez <ARR552@users.noreply.github.com>

tclemos added 3 commits June 7, 2023 15:16

fix concurrent web socket writes

d86eb70

fix eth_syncing

d815237

fix custom trace internal tx call error handling and update prover

cc8aac8

tclemos requested review from ToniRamirezM and agnusmor June 8, 2023 15:43

cla-bot bot added the cla-signed label Jun 8, 2023

ToniRamirezM previously approved these changes Jun 8, 2023

View reviewed changes

tclemos changed the title ~~Hotfix/v0.1.x~~ Hotfix/v0.1.3 Jun 8, 2023

add test to custom tracer depth issue; fix internal call error and ga…

a0a1196

…s used

tclemos dismissed ToniRamirezM’s stale review via a0a1196 June 8, 2023 16:36

tclemos added 2 commits June 8, 2023 14:54

fix custom tracer for internal tx with error and no more steps after it

0adbad4

remove debug code

e4cd9c1

ARR552 reviewed Jun 9, 2023

View reviewed changes

ToniRamirezM previously approved these changes Jun 9, 2023

View reviewed changes

Make max grpc message size configurable (#2179)

489d0ae

* make max grpc message size configurable * fix state tests * fix tests * fix tests

ToniRamirezM dismissed their stale review via 489d0ae June 9, 2023 14:06

ToniRamirezM added this to the v0.1.3 milestone Jun 9, 2023

agnusmor and others added 2 commits June 10, 2023 00:02

get SequencerNodeURI from SC if empty and not IsTrustedSequencer

8f964cb

Merge pull request #2182 from 0xPolygonHermez/hotfix/sequencer-node-uri

20e172d

Get SequencerNodeURI from SC

agnusmor assigned tclemos Jun 12, 2023

ToniRamirezM and others added 2 commits June 13, 2023 20:28

move log for the best fitting tx (#2192)

4ef3d75

ToniRamirezM requested a review from xavier-romero June 14, 2023 09:33

ToniRamirezM added the config label Jun 14, 2023

agnusmor added 2 commits June 20, 2023 19:54

fix load zkCounters from pool

6d0fe2d

remove unnecessary log.info

3b411fa

agnusmor mentioned this pull request Jun 21, 2023

Intermittent write errors with some JSON-RPC websocket connections #1965

Open

agnusmor and others added 3 commits June 21, 2023 14:53

Merge pull request #2210 from 0xPolygonHermez/hotfix/fix-load-zkcounters

906bdef

Fix load zkCounters from pool

add custom tracer support to CREATES opcode without depth increase (#…

a29d721

…2213)

logs

0b33b87

agnusmor and others added 10 commits June 21, 2023 19:48

fix getting stateroot from previous batch (GetWIPBatch)

860f0e7

logs

d95af12

Fix GetWipBatch when previous last batch is a forced batch

40ca563

fix forcedBatch trusted state

530c1f6

Revert "fix getting stateroot from previous batch (GetWIPBatch)"

62dfab1

This reverts commit 860f0e7.

force GHA

c6a2654

Merge pull request #2214 from 0xPolygonHermez/hotfix/get-wip-batch-fb

6538e3b

Fix GetWIPBatch when previous last batch is a forced batch

Merge pull request #2216 from 0xPolygonHermez/hotfix/forced_batch

69fef3f

Hotfix/forced batch

add pool limits (#2189)

a074a48

Hotfix/batch l2 data (#2223)

b5518aa

* Fix BatchL2Data * Force GHA

ToniRamirezM approved these changes Jun 26, 2023

View reviewed changes

ToniRamirezM merged commit c7aabd4 into main Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hotfix/v0.1.3#2173

Hotfix/v0.1.3#2173
ToniRamirezM merged 26 commits intomainfrom
hotfix/v0.1.X

tclemos commented Jun 8, 2023 •

edited

Loading

Uh oh!

ARR552 Jun 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tclemos commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Reviewers

Uh oh!

ARR552 Jun 9, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tclemos commented Jun 8, 2023 •

edited

Loading