This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Fix GetWIPBatch when previous last batch is a forced batch#2214
Merged
agnusmor merged 1 commit intohotfix/v0.1.Xfrom Jun 22, 2023
Merged
Fix GetWIPBatch when previous last batch is a forced batch#2214agnusmor merged 1 commit intohotfix/v0.1.Xfrom
agnusmor merged 1 commit intohotfix/v0.1.Xfrom
Conversation
ToniRamirezM
approved these changes
Jun 22, 2023
ARR552
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes an error in the GetWIPBatch when trying to decode the txs of the previous last batch. If the previous last batch was a forced batch containing invalid data, the DecodeTxs function failing when trying to decode this data and it returned an error that was managed as a fatal, stopping the execution of the sequencer.
Reviewing the code we figure out that was not needed to call DecodeTxs for the previous last batch as this info is not needed to check if we need to get the last stateroot from the l2block data or from the previous last batch. Removing this DecodeTxs we fix any decode problem with forceb batches in this point
Reviewers
Main reviewers:
@ARR552
@ToniRamirezM
@tclemos