This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Fix load zkCounters from pool#2210
Merged
agnusmor merged 2 commits intohotfix/v0.1.Xfrom Jun 21, 2023
Merged
Conversation
tclemos
approved these changes
Jun 20, 2023
ToniRamirezM
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the load of the zkCounters values in the function GetNonWIPTxsByStatus as it was not adding the zkCounters fields to the query and therefore the zkCounters was 0 for all the counters. When adding these txs to the worker, it was calculating a wrong efficiency, as all the zkcounters were 0. This bug was reported here (bug bounty):
https://polygon.atlassian.net/browse/ASF-285
Reviewers
Main reviewers:
@tclemos
@ToniRamirezM
@Psykepro