Conversation
drahnr
added
the
no changelog
SantiagoPittella
approved these changes
Sep 3, 2025
Collaborator
SantiagoPittella
left a comment
SantiagoPittella
left a comment
There was a problem hiding this comment.
Overall looks good, left a couple comments.
The update to RangeInclusive in the missing functions is to be made in a different PR? I can address the CheckNullifiersByPrefix one in my PR and tackle the other on a separate one.
Contributor
Author
I added the fixes in this PR. I'd suggest to merge yours first, and I'll deal with the remaining |
Mirko-von-Leipzig
approved these changes
Sep 4, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I assumed the insertion code was just copied over and didn't proof read it too closely
Mirko-von-Leipzig
approved these changes
Sep 4, 2025
Contributor
Author
|
Insertion code was carbon copied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses parts of
Ref #1134
Ref #1161