-
Notifications
You must be signed in to change notification settings - Fork 99
Open
Refactoring
0 / 30 of 3 issues completed
Copy link
Description
Derived from comments on #1148
Related to #1134
Code Organization
- File Structure
- Suggestion to further split files under namespaces (e.g.,
notes/mod.rs,notes/network_notes.rs) - Consider moving insert statements from
insertions.rsto their corresponding entity files - Consider grouping test-specific functions in separate sections
- Suggestion to further split files under namespaces (e.g.,
Documentation
- Add missing function docs
- Move SQL statements to doc comments
- Document parameter limits
Performance Considerations
-
Data Structures
-
Query Optimization
- Some complex queries (like note selection) might need optimization
- Consider splitting complex queries into separate functions
- Need to address potential scalability issues with large result sets
-
Data Storage
- Need to optimize nullifier tree rebuilding for large datasets #1202
- Upgrade to large capacity SMT #1189 / Consider migrating to
LargeSmtfor better scalability
Technical Debt
-
Naming Conventions
- Normalize parameter naming (e.g.,
block_from/block_toinstead of various alternatives) - Improve consistency in parameter naming across different queries
- Normalize parameter naming (e.g.,
-
Error Handling
- Ensure proper limit checks on all query parameters
- Add missing parameter limit checks for some functions
Reactions are currently unavailable
Sub-issues
Metadata
Metadata
Assignees
Labels
storeRelated to the store componentRelated to the store component