Merged
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-get-note-script-by-root-endpoint
branch
from
7c7fe71 to
307b3ca
Compare
SantiagoPittella
requested review from
Mirko-von-Leipzig,
bobbinth,
drahnr and
igamigo
bobbinth
approved these changes
Sep 2, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
Mirko-von-Leipzig
approved these changes
Sep 3, 2025
drahnr
reviewed
Sep 3, 2025
| // FROM | ||
| // note_scripts | ||
| // WHERE | ||
| // root = ?1; |
Contributor
There was a problem hiding this comment.
Note: in #1193 these comments get moved to the doc comments
# Raw SQL
\`\`\`sql
SELECT ..
\`\`\`
Collaborator
Author
There was a problem hiding this comment.
Awesome, I moved the query to doc comments already 👌🏼
drahnr
approved these changes
Sep 3, 2025
bobbinth
deleted the
santiagopittella-get-note-script-by-root-endpoint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1187