Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track resolution of facebook/flipper#1171 and adapt when we can. #4264

Closed
chrisbobbe opened this issue Sep 21, 2020 · 0 comments
Closed

Track resolution of facebook/flipper#1171 and adapt when we can. #4264

chrisbobbe opened this issue Sep 21, 2020 · 0 comments
Labels
a-iOS blocked on other work To come back to after another related PR, or some other task. upstream: RN Issues related to an issue in React Native

Comments

@chrisbobbe
Copy link
Contributor

As alluded to in 9a144c5, we should track the resolution of facebook/flipper#1171 (currently stalled on someone not providing a reproduction recipe), and adjust our project to use that better solution if and when the change propagates far enough that we can take it. The change we're waiting for is for Flipper to use one later patch release of a cryptography library than it does currently (or to use a different library altogether, I guess). It will likely mean waiting for a release of Flipper, and also waiting for a release of React Native that takes that Flipper release and addresses any issues with it.

When possible, the workaround to revert is the addition of ENABLE_BITCODE = NO; in our project.pbxproj. The line was added in 9a144c5, to correspond with facebook/react-native@b4d1fcfb2#diff-7fd6339d18c83813afdda60e2e314cefR498.

@chrisbobbe chrisbobbe added a-iOS upstream: RN Issues related to an issue in React Native blocked on other work To come back to after another related PR, or some other task. labels Sep 21, 2020
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 5, 2021
As we made plans for in the RN v0.62 upgrade.

In the previous commit, the OpenSSL-Universal pod was taken to
1.1.180, which is even later than 1.0.2.20, which is what we'd been
waiting for.

Fixes: zulip#4264
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue May 5, 2021
As we made plans for in the RN v0.62 upgrade.

In the previous commit, the OpenSSL-Universal pod was taken to
1.1.180, which is even later than 1.0.2.20, which is what we'd been
waiting for.

Fixes: zulip#4264
@gnprice gnprice closed this as completed in 5997d48 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-iOS blocked on other work To come back to after another related PR, or some other task. upstream: RN Issues related to an issue in React Native
Projects
None yet
Development

No branches or pull requests

1 participant