Bump OpenSSL-Universal pod dependency to 1.0.2.20

[mikehardy]

Per comment in #485 (comment) it appears that OpenSSL will have bitcode information in it now which should solve problems like those experienced in #485 and it's connected issues

Summary

Fixes #485 for real?

Flipper depends on OpenSSL library which does not have bitcode enabled, which means that it fails on real devices as noted in #485

Changelog

Upgrade OpenSSL dependency to one that enables bitcode

Test Plan

This is perhaps more of a speculative PR, it's a build system thing and fundamental enough I am assuming (read as: possibly wrong) that CI + basic tests will show that there are no regressions. After which point the results of this can be issued as a @next or similar for people to see if they can remove the bitcode-disabling workarounds they've had to put in to work around #485

[cekkaewnumchai]

I don't have context on iOS side. Will let @priteshrnandgaonkar look at it.

[priteshrnandgaonkar]

I will try this locally and check it tomorrow.

[priteshrnandgaonkar]

I tried using the latest openssl dependency with bitcode set to enabled.I got the following error

Undefined symbols for architecture x86_64:
  "___darwin_check_fd_set_overflow", referenced from:
      _RAND_poll in libcrypto.a(rand_unix.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[priteshrnandgaonkar]

This change will break the sample app

[mikehardy]

That's a shame - thank you for checking @priteshrnandgaonkar ! I'm not sure what time I'll have available for this, so if anyone else has time please try things - I'd love to see a fix for this but probably am not the best person to submit it

[mikehardy]

I had just enough time to scan the diff from the version currently used (1.0.2.19) to current and the only chunk not related to a transitive OpenSSL dependency upgrade was this:

krzyzanowskim/OpenSSL@1.0.219...master#diff-0b83f9dedf40d7356e5ca147a077acb4

Where they enable bitcode. There was nothing in there that would alter the build, that I see. How can 1.0.2.19 work but 1.0.2.20 not? Very strange.

[RoderickJDunn]

@mikehardy I was able to get my RN project to build with bitcode enabled using this branch. I'm on X-Code 11.5.

Here are the changes to react_native_pods.rb file:

pod 'Flipper', :git => 'https://github.com/mikehardy/flipper', :branch => 'patch-1', :configuration => 'Debug'
pod 'Flipper-Folly', :podspec => 'https://raw.githubusercontent.com/mikehardy/flipper/patch-1/iOS/Podspecs/Flipper-Folly.podspec', :configuration => 'Debug'

Whole file below for reference.

def use_react_native! (options={})
  # The prefix to the react-native
  prefix = options[:path] ||= "../node_modules/react-native"

  # Include Fabric dependencies
  fabric_enabled = options[:fabric_enabled] ||= false

  # Include DevSupport dependency
  production = options[:production] ||= false

  # The Pods which should be included in all projects
  pod 'FBLazyVector', :path => "#{prefix}/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "#{prefix}/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "#{prefix}/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "#{prefix}/Libraries/TypeSafety"
  pod 'React', :path => "#{prefix}/"
  pod 'React-Core', :path => "#{prefix}/"
  pod 'React-CoreModules', :path => "#{prefix}/React/CoreModules"
  pod 'React-RCTActionSheet', :path => "#{prefix}/Libraries/ActionSheetIOS"
  pod 'React-RCTAnimation', :path => "#{prefix}/Libraries/NativeAnimation"
  pod 'React-RCTBlob', :path => "#{prefix}/Libraries/Blob"
  pod 'React-RCTImage', :path => "#{prefix}/Libraries/Image"
  pod 'React-RCTLinking', :path => "#{prefix}/Libraries/LinkingIOS"
  pod 'React-RCTNetwork', :path => "#{prefix}/Libraries/Network"
  pod 'React-RCTSettings', :path => "#{prefix}/Libraries/Settings"
  pod 'React-RCTText', :path => "#{prefix}/Libraries/Text"
  pod 'React-RCTVibration', :path => "#{prefix}/Libraries/Vibration"
  pod 'React-Core/RCTWebSocket', :path => "#{prefix}/"

  unless production
    pod 'React-Core/DevSupport', :path => "#{prefix}/"
  end

  pod 'React-cxxreact', :path => "#{prefix}/ReactCommon/cxxreact"
  pod 'React-jsi', :path => "#{prefix}/ReactCommon/jsi"
  pod 'React-jsiexecutor', :path => "#{prefix}/ReactCommon/jsiexecutor"
  pod 'React-jsinspector', :path => "#{prefix}/ReactCommon/jsinspector"
  pod 'React-callinvoker', :path => "#{prefix}/ReactCommon/callinvoker"
  pod 'ReactCommon/turbomodule/core', :path => "#{prefix}/ReactCommon"
  pod 'Yoga', :path => "#{prefix}/ReactCommon/yoga", :modular_headers => true

  pod 'DoubleConversion', :podspec => "#{prefix}/third-party-podspecs/DoubleConversion.podspec"
  pod 'glog', :podspec => "#{prefix}/third-party-podspecs/glog.podspec"
  pod 'Folly', :podspec => "#{prefix}/third-party-podspecs/Folly.podspec"

  if fabric_enabled
    pod 'React-Fabric', :path => "#{prefix}/ReactCommon"
    pod 'React-graphics', :path => "#{prefix}/ReactCommon/fabric/graphics"
    pod 'React-jsi/Fabric', :path => "#{prefix}/ReactCommon/jsi"
    pod 'React-RCTFabric', :path => "#{prefix}/React"
    pod 'Folly/Fabric', :podspec => "#{prefix}/third-party-podspecs/Folly.podspec"
  end
end

def use_flipper!(versions = {})
  versions['Flipper'] ||= '~> 0.42'
  versions['Flipper-DoubleConversion'] ||= '1.1.7'
  versions['Flipper-Folly'] ||= '~> 2.2'
  versions['Flipper-Glog'] ||= '0.3.6'
  versions['Flipper-PeerTalk'] ||= '~> 0.0.4'
  versions['Flipper-RSocket'] ||= '~> 1.1'
  pod 'FlipperKit', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/SKIOSNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitUserDefaultsPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitReactPlugin', versions['Flipper'], :configuration => 'Debug'
  # List all transitive dependencies for FlipperKit pods
  # to avoid them being linked in Release builds
  pod 'Flipper', :git => 'https://github.com/mikehardy/flipper', :branch => 'patch-1', :configuration => 'Debug'
  pod 'Flipper-DoubleConversion', versions['Flipper-DoubleConversion'], :configuration => 'Debug'
  pod 'Flipper-Folly', :podspec => 'https://raw.githubusercontent.com/mikehardy/flipper/patch-1/iOS/Podspecs/Flipper-Folly.podspec', :configuration => 'Debug'
  pod 'Flipper-Glog', versions['Flipper-Glog'], :configuration => 'Debug'
  pod 'Flipper-PeerTalk', versions['Flipper-PeerTalk'], :configuration => 'Debug'
  pod 'Flipper-RSocket', versions['Flipper-RSocket'], :configuration => 'Debug'
  pod 'FlipperKit/Core', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/CppBridge', :configuration => 'Debug'
  pod 'FlipperKit/FBCxxFollyDynamicConvert', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FBDefines', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FKPortForwarding', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitHighlightOverlay', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutTextSearchable', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
end

# Post Install processing for Flipper
def flipper_post_install(installer)
  installer.pods_project.targets.each do |target|
    if target.name == 'YogaKit'
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.1'
      end
    end
  end
end

[mikehardy]

What is the build/test difference between @priteshrnandgaonkar and you @RoderickJDunn ? I see an x86_64 symbol referenced from the failure above, @RoderickJDunn can you confirm you tested on simulator and real device? I assume release mode is not that important as flipper is a debug tool so probably just debug both, but it makes me think a simulator build in debug might fail and I'm not sure what exactly was tested

[RoderickJDunn]

@mikehardy Yes, the app builds/runs on both a real device and simulator. The 'Valid Architectures' listed under target build settings are: arm64 arm64e armv7 armv7s.
So x86_64 / i386 don't seem to be required for my particular setup.

Re: debug/release modes... correct I've only tried building in debug mode.

[mikehardy]

@priteshrnandgaonkar can you point me to any documentation, or list the exact steps used to demonstrate the failure you saw? I'd like to try to reproduce and resolve this if possible, it strikes me that not having access to current (and possible future) updates of a cryptography library is not a good long-term plan, and this should be close to working if we can get it done

[chrisbobbe]

Really briefly (I'm wary that this will be irrelevant, and I don't have evidence; I'm still working through the RN v0.62 upgrade): Could that failure be addressed by correctly following the manual Xcode steps linked from the RN v0.62 upgrade guide?

[mikehardy]

@chrisbobbe without knowing the exact steps to reproduce the failure, I couldn't speculate. We have one reported success and one reported failure, so I think the burden is on the failure case to demonstrate the failure reproducibly, then I/we dig in and fix that thing :-)

[chrisbobbe]

Makes sense. Also, a question for @priteshrnandgaonkar: Was that error definitely not observed with the older version (1.0.2.19) in the same environment? Or is the error also observed there, or else was there perhaps a change in the environment (even an Xcode version, etc.)?

[tastafur]

The version 1.0.2.19 not work bitcode in 0.63 version

[mikehardy]

@tastafur that's the entire reason this PR exists. Workarounds are available in the linked issue #485 (comment) - do you have the time to test this PR and help move it forward? We're still waiting on some one that can reproduce the steps taken by @priteshrnandgaonkar where this PR apparently did not work. That's where we are blocked now.

[cosmith]

I hit the same issue and can confirm that this change fixed the build for me. So now we're 2 to 1 ;)

[mikehardy]

@cosmith glad to hear it works! But quality is not a vote of course 😆 I believe we are still here:

We're still waiting on some one that can reproduce the steps taken by @priteshrnandgaonkar where this PR apparently did not work. That's where we are blocked now.

If the maintainers say there is a case the patch doesn't work, I can't vote for my own patch! I just don't know what test was run and exactly how it was run to reproduce the problem so that I/we can fix it and move forward

[priteshrnandgaonkar]

I verified that it works on the current SampleSwift and Sample apps. I will update the Flipper-Folly and make a release

[mikehardy]

Fantastic! :-) thanks @priteshrnandgaonkar

[mikehardy]

upstream has a merged fix now external to this PR, this is resolved