Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play Zulip's distinctive notification sound on Android #340

Closed
gnprice opened this issue Oct 26, 2023 · 0 comments · Fixed by #982
Closed

Play Zulip's distinctive notification sound on Android #340

gnprice opened this issue Oct 26, 2023 · 0 comments · Fixed by #982
Assignees
@rajveermalviya
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Milestone
Beta 3: Summer 2024

Comments

@gnprice
Copy link
Member

gnprice commented Oct 26, 2023

In zulip-mobile we have a distinctive notification sound we created a couple of years ago, which we use on Android by default. We also have a suite of variant sounds which we provide for the user to choose from if they use the system notification settings.

We should do the same here. My initial implementation of #320 / #122 won't do so, in order to manage complexity.

We should also eventually do so on iOS. That will be tracked separately, because it's a feature we don't yet have in zulip-mobile either: zulip/zulip-mobile#3101 .
@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-notifications labels Oct 26, 2023
@gnprice gnprice added this to the Beta milestone Oct 26, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 2, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
aafef49 
Updates: zulip#340
@rajveermalviya rajveermalviya mentioned this issue Jun 2, 2024
Closed
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 6, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
0ffeefa 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 8, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
eaf25e6 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Aug 23, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
47cd69c 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Aug 23, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
c82baa1 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Aug 23, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
a018fe3 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Aug 23, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
4020759 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Sep 11, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
379d4dc 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Sep 11, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
c5d12fb 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Sep 11, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
16b9f47 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Sep 27, 2024
@rajveermalviya
notif: Use Zulip's notification sound on Android
ca1eefd 
Updates: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 4, 2024
@rajveermalviya
notif: Support migration of Android notification channels
71e2694 
Needed for zulip#340 updating notification channels to use custom notification sound.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 4, 2024
@rajveermalviya
notif: Support migration of Android notification channels
8afb983 
Needed for zulip#340, when updating notification channels to use a custom
notification sound.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 4, 2024
@rajveermalviya
notif: Use Zulip's custom notification sound on Android
0363db8 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 4, 2024
@rajveermalviya
notif: Use Zulip's custom notification sound on Android
a7ffb60 
Fixes: zulip#340
This was referenced Oct 4, 2024
Merged
Merged
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 5, 2024
@rajveermalviya
notif: Support migration of Android notification channels
c85adc9 
Needed for zulip#340, when updating notification channels to use a custom
notification sound.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 7, 2024
@rajveermalviya
notif: Use Zulip's custom notification sound on Android
efdb971 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 8, 2024
@rajveermalviya
notif: Support migration of Android notification channels
b3a5b2a 
Needed for zulip#340, when updating notification channels to use a custom
notification sound.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 8, 2024
@rajveermalviya
notif: Support migration of Android notification channels
00deaa6 
Needed for zulip#340, when updating notification channels to use a custom
notification sound.
donnywellson pushed a commit to donnywellson/zulip-flutter that referenced this issue Oct 9, 2024
@rajveermalviya @donnywellson
notif: Support migration of Android notification channels
f64a260 
Needed for zulip#340, when updating notification channels to use a custom
notification sound.
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 9, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
d6a11af 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 9, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
0327a56 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 9, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
e1b117b 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 10, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
fc9d6f6 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 28, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
1305eb2 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Oct 30, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
13ba923 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 6, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
90c94a0 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 6, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
6473c29 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 6, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
f531bda 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 6, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
e58b4a2 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 9, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
8477154 
Fixes: zulip#340
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 9, 2024
@rajveermalviya
notif: Use Zulip's distinct notification sound on Android
687e5eb 
Fixes: zulip#340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajveermalviya rajveermalviya

Labels
a-Android Issues specific to Android, or requiring Android-specific work a-notifications
Projects
Flutter app
Status: Done
Milestone
Beta 3: Summer 2024
Development

Successfully merging a pull request may close this issue.

notif: Use Zulip's custom notification sound on Android rajveermalviya/zulip-flutter
2 participants
@gnprice @rajveermalviya