notif: Use Zulip's notification sound on Android

Updates: zulip#340
rajveermalviya · Aug 23, 2024 · 47cd69c · 47cd69c
1 parent 57a5769
commit 47cd69c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/android/app/src/main/res/raw/chime3.m4a b/android/app/src/main/res/raw/chime3.m4a
diff --git a/android/app/src/main/res/raw/keep.xml b/android/app/src/main/res/raw/keep.xml
@@ -12,5 +12,5 @@
        https://github.com/zulip/zulip-flutter/issues/528
      -->
 <resources xmlns:tools="http://schemas.android.com/tools"
-    tools:keep="@drawable/zulip_notification"
+    tools:keep="@drawable/zulip_notification,@raw/chime3"
     />
diff --git a/lib/notifications/display.dart b/lib/notifications/display.dart
@@ -25,7 +25,9 @@ AndroidNotificationHostApi get _androidHost => ZulipBinding.instance.androidNoti
 /// Service for configuring our Android "notification channel".
 class NotificationChannelManager {
   @visibleForTesting
-  static const kChannelId = 'messages-1';
+  static const kChannelId = 'messages-2';
+
+  static const kDefaultSoundResourceName = 'chime3'; // 'Zulip - Chime.m4a'
 
   /// The vibration pattern we set for notifications.
   // We try to set a vibration pattern that, with the phone in one's pocket,
@@ -77,8 +79,8 @@ class NotificationChannelManager {
       name: 'Messages', // TODO(i18n)
       importance: NotificationImportance.high,
       lightsEnabled: true,
+      soundResourceName: kDefaultSoundResourceName,
       vibrationPattern: kVibrationPattern,
-      // TODO(#340) sound
     ));
   }
 }