-
-
Notifications
You must be signed in to change notification settings - Fork 392
zulip/__init__.py: Adds delete_topic method #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pradhvan
wants to merge
1
commit into
zulip:main
Choose a base branch
from
Pradhvan:API-Delete-Topic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#!/usr/bin/env python3 | ||
|
||
import argparse | ||
import zulip | ||
|
||
|
||
usage = """delete-topic <stream_id/stream_name, topic_name> | ||
|
||
Example: delete-topic 1 "Denmark1" or "Denmark" "Denmark1" | ||
""" | ||
|
||
parser = zulip.add_default_arguments(argparse.ArgumentParser(usage=usage)) | ||
parser.add_argument('stream_id') | ||
parser.add_argument('topic_name', type=str) | ||
options = parser.parse_args() | ||
|
||
client = zulip.init_from_options(options) | ||
if (type(options.stream_id) == str): | ||
options.stream_id = client.get_stream_id(options.stream_id) | ||
|
||
print(client.delete_topic(options.stream_id.get("stream_id"), options.topic_name)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pradhvan Have you tried manually testing this ? I am getting an error while trying to pass a stream id (i.e. int) as argument. Seems like it treats it as a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akashaviator let me try manually testing it. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pradhvan have you tested this?
If you don't have time, can @akashaviator take over finishing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timabbott sorry for the delay. I will test and update this. So that @akashaviator can review and merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akashaviator can you take this over? Sorry but I am bit stuck on things and won't be able to give this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's not merged, I can take this up again. @akashaviator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pradhvan are you working on this? Just asking since i did not see it claimed. Thanks!