zulip/__init__.py: Adds delete_topic method #603
Conversation
Adds a method delete_topic which calls the url '/streams/stream_id/delete_topic ' with topic_name passed as data Closes zulip#534
Pradhvan
force-pushed
the
API-Delete-Topic
branch
from
fdfcafa to
27dbffc
Compare
|
@akashaviator can you review this? |
| options = parser.parse_args() | ||
|
|
||
| client = zulip.init_from_options(options) | ||
| if (type(options.stream_id) == str): |
There was a problem hiding this comment.
@Pradhvan Have you tried manually testing this ? I am getting an error while trying to pass a stream id (i.e. int) as argument. Seems like it treats it as a string.
There was a problem hiding this comment.
@akashaviator let me try manually testing it. 😄
There was a problem hiding this comment.
@Pradhvan have you tested this?
If you don't have time, can @akashaviator take over finishing this?
There was a problem hiding this comment.
@timabbott sorry for the delay. I will test and update this. So that @akashaviator can review and merge this.
There was a problem hiding this comment.
@akashaviator can you take this over? Sorry but I am bit stuck on things and won't be able to give this time.
There was a problem hiding this comment.
Since it's not merged, I can take this up again. @akashaviator
There was a problem hiding this comment.
@Pradhvan are you working on this? Just asking since i did not see it claimed. Thanks!
|
Go for it!
…On Wed, Oct 21, 2020 at 9:43 PM Pradhvan Bisht ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In zulip/zulip/examples/delete-topic
<#603 (comment)>
:
> +import argparse
+import zulip
+
+
+usage = """delete-topic <stream_id/stream_name, topic_name>
+
+Example: delete-topic 1 "Denmark1" or "Denmark" "Denmark1"
+"""
+
+parser = zulip.add_default_arguments(argparse.ArgumentParser(usage=usage))
+parser.add_argument('stream_id')
+parser.add_argument('topic_name', type=str)
+options = parser.parse_args()
+
+client = zulip.init_from_options(options)
+if (type(options.stream_id) == str):
Since it's not merged, I can take this up again. @akashaviator
<https://github.com/akashaviator>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU6NWQS6R24O5DEEW73MZLSL6Z7PANCNFSM4OA2T2QA>
.
|
|
I think this deserves some extra testings to get merged. |
Adds a method delete_topic which calls the url '/streams/stream_id/delete_topic
' with topic_name passed as data
Closes #534