v0.7.0 #613
Merged
v0.7.0 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericfreese
commented
Jun 4, 2021
•
ericfreese
commented
- Review readme
- Update changelog
- Bump version
- Tag version (on master after PR is merged)
We are already using this method in other places. For example: `ZSH_AUTOSUGGEST_USE_ASYNC`
To avoid wrapping the built-in widgets (e.g. `autosuggest-fetch`, `autosuggest-toggle`), we were ignoring all widgets whose names start with `autosuggest-`. This had the downside of preventing wrapping of user-defined widgets whose names happened to also start with that prefix. By being more specific about the exact built-in widgets we want to avoid wrapping, we can allow users to define widgets whose names start with `autosuggest-`. See GitHub issue #496.
Allow users to override the default by unsetting (or setting) the ZSH_AUTOSUGGEST_USE_ASYNC variable. See GitHub issue #498.
See GitHub issue #503
Add links to documentation on zsh glob patterns to the readme
Be more specific about the built-in widgets we want to avoid wrapping
cleanup: Use more idiomatic method of checking if var is set
Enable async mode by default in newer versions of zsh
Write mock history to a temp file and load it directly with `fc -R` instead of running each command individually to build up the history.
There's something funny occasionally happening when `with_history` is
used twice in the same test. It seems to be happening more frequently
since asynchronous mode was enabled by default. My guess is it has
something to do with the `C-c` keys being sent toward the end not
consistently terminating the prompt. But I'm really not sure how it
would ever get into a `then` block like it seems to:
```
Failure/Error: wait_for { session.content }.to eq('echo "hello\nworld"')
expected: "echo \"hello\\nworld\""
got: "then> echo \"hello\\"
```
Sticking to only one `with_history` per terminal session (per test)
seems to fix the flakiness.
I also removed an old test case because I could not understand why it
was necessary and so couldn't write a good description for it. Could be
we'll need to add it back in at some point.
To reproduce:
1. Run `zsh -f`.
2. Run this:
function bye() { BUFFER=bye }
zle -N bye
bindkey '^B' bye
print -s 'hibye unexpected'
source ~/zsh-autosuggestions/zsh-autosuggestions.zsh
3. Type `hi` and press Ctrl-B.
Expected: POSTBUFFER is empty.
Actual: POSTBUFFER is " unexpected".
Fixes/flaky ci
[fix] install this plugin aside other plugins
…her-plugins Update INSTALL.md
Disable ^C async workaround for zsh version 5.8 and later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.