Disable ^C async workaround for zsh version 5.8 and later #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericfreese
reviewed
Jun 3, 2021
| @@ -810,7 +810,8 @@ _zsh_autosuggest_async_request() { | |||
|
|
|||
| # There's a weird bug here where ^C stops working unless we force a fork | |||
There was a problem hiding this comment.
Thanks for the quick PR. Not a huge deal, but can you update this comment to read something like "There's a bug in older versions where ^C ..."?
|
Just leaving a reminder for myself that I need to add 5.8 to the ZSH_VERSIONS file and push a new docker image |
|
Sorry, I missed this email, when I rediscovered it the pr was already
merged.
|
|
Thank you for making a tag and for all your work!)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is fixed in recent version of zsh, so the workaround is not needed anymore for fresh zsh:
#364