Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable gzip compression for binary requests #1262

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Disable gzip compression for binary requests #1262

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17a17a4
Disable gzip compression for binary requests
t1m0thyj Jan 11, 2022
cab416e
Add concurrency and timeout to GH workflow
t1m0thyj Jan 11, 2022
183bfd4
Comment out Accept-Encoding header in unit tests
t1m0thyj Jan 11, 2022
4bf0a0a
Update Imperative version
t1m0thyj Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/zowe-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ jobs:
NODE: ${{ matrix.node-version }}
NODE_OPTIONS: --max_old_space_size=4096

timeout-minutes: 60

concurrency:
group: ${{ matrix.os }}-node-${{ matrix.node-version }}-ci-${{ github.ref }}
cancel-in-progress: true
Comment on lines +39 to +43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it! 😋


if: (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository) && !contains(github.event.head_commit.message, '[ci skip]')

steps:
Expand Down
110 changes: 55 additions & 55 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions packages/cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,21 @@

All notable changes to the Zowe CLI package will be documented in this file.

## Recent Changes

- BugFix: Disable gzip compression for z/OSMF requests that download binary files. [#1170](https://github.com/zowe/zowe-cli/issues/1170)

## `6.37.1`

- BugFix: Update Imperative to absorb bugfixes introduced in version `4.17.2`.

## `6.37.0`

- Enhancement: Added new feature to manage zos-logs. z/OSMF version 2.4 or higher is required. Ensure that the [z/OSMF Operations Log Support is available via APAR and associated PTFs](https://www.ibm.com/support/pages/apar/PH35930). [Issue 1104](https://github.com/zowe/zowe-cli/issues/1104)
- Enhancement: Added new feature to manage zos-logs. z/OSMF version 2.4 or higher is required. Ensure that the [z/OSMF Operations Log Support is available via APAR and associated PTFs](https://www.ibm.com/support/pages/apar/PH35930). [#1104](https://github.com/zowe/zowe-cli/issues/1104)

## `6.36.1`

- BugFix: Fixed an issue where plugin install and uninstall did not work with NPM version 8. [#683](https://github.com/zowe/imperative/issues/683)
- BugFix: Fixed an issue where plugin install and uninstall did not work with NPM version 8. [Imperative #683](https://github.com/zowe/imperative/issues/683)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😋


## `6.36.0`

Expand Down
4 changes: 4 additions & 0 deletions packages/zosfiles/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the Zowe z/OS files SDK package will be documented in this file.

## Recent Changes

- BugFix: Disable gzip compression for z/OSMF requests that download binary files. [#1170](https://github.com/zowe/zowe-cli/issues/1170)

## `6.32.1`

- Updated Imperative version
Expand Down
16 changes: 12 additions & 4 deletions packages/zosfiles/__tests__/__unit__/methods/download/Download.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ describe("z/OS Files - Download", () => {

expect(zosmfGetFullSpy).toHaveBeenCalledTimes(1);
expect(zosmfGetFullSpy).toHaveBeenCalledWith(dummySession, {resource: endpoint,
reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
// TODO:gzip
// reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
reqHeaders: [ZosmfHeaders.X_IBM_BINARY],
responseStream: fakeWriteStream,
normalizeResponseNewLines: false /* don't normalize newlines, binary mode*/,
task: undefined /* no progress task */});
Expand Down Expand Up @@ -233,7 +235,9 @@ describe("z/OS Files - Download", () => {

expect(zosmfGetFullSpy).toHaveBeenCalledTimes(1);
expect(zosmfGetFullSpy).toHaveBeenCalledWith(dummySession, {resource: endpoint,
reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
// TODO:gzip
// reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
reqHeaders: [ZosmfHeaders.X_IBM_BINARY],
responseStream: fakeWriteStream,
normalizeResponseNewLines: false, /* no normalizing new lines, binary mode*/
task: undefined /*no progress task*/});
Expand Down Expand Up @@ -947,7 +951,9 @@ describe("z/OS Files - Download", () => {
// false, /* don't normalize new lines in binary*/
// undefined /* no progress task */);
expect(zosmfGetFullSpy).toHaveBeenCalledWith(dummySession, {resource: endpoint,
reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
// TODO:gzip
// reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
reqHeaders: [ZosmfHeaders.X_IBM_BINARY],
responseStream: fakeStream,
normalizeResponseNewLines: false, /* don't normalize new lines in binary*/
task: undefined /* no progress task */});
Expand Down Expand Up @@ -1049,7 +1055,9 @@ describe("z/OS Files - Download", () => {

expect(zosmfGetFullSpy).toHaveBeenCalledTimes(1);
expect(zosmfGetFullSpy).toHaveBeenCalledWith(dummySession, {resource: endpoint,
reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
// TODO:gzip
// reqHeaders: [ZosmfHeaders.X_IBM_BINARY, ZosmfHeaders.ACCEPT_ENCODING],
reqHeaders: [ZosmfHeaders.X_IBM_BINARY],
responseStream: fakeStream,
normalizeResponseNewLines: false, /* don't normalize new lines in binary */
task: undefined /* no progress task */});
Expand Down
Loading