Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gzip compression for binary requests #1262

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jan 11, 2022

Workaround for #1170 until z/OSMF fixes truncation of gzipped binary data.

Added the "TODO:gzip" comment to places where we'll want to add back the "Accept-Encoding" header in the future.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Comment on lines +39 to +43
timeout-minutes: 60

concurrency:
group: ${{ matrix.os }}-node-${{ matrix.node-version }}-ci-${{ github.ref }}
cancel-in-progress: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing it! 😋


## `6.36.1`

- BugFix: Fixed an issue where plugin install and uninstall did not work with NPM version 8. [#683](https://github.com/zowe/imperative/issues/683)
- BugFix: Fixed an issue where plugin install and uninstall did not work with NPM version 8. [Imperative #683](https://github.com/zowe/imperative/issues/683)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😋

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1262 (183bfd4) into master (6e96c21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 183bfd4 differs from pull request most recent head 4bf0a0a. Consider uploading reports for the commit 4bf0a0a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         358      358           
  Lines        5228     5229    +1     
  Branches      715      716    +1     
=======================================
+ Hits         4753     4754    +1     
  Misses        470      470           
  Partials        5        5           
Impacted Files Coverage Δ
packages/zosfiles/src/utils/ZosFilesUtils.ts 97.95% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35f4ff...4bf0a0a. Read the comment docs.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@t1m0thyj t1m0thyj merged commit e0810a8 into master Jan 11, 2022
@t1m0thyj t1m0thyj deleted the fix-gzip-truncate branch January 11, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants