Fix issue with 32bit architecture on big numbers' random generation #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with 32bit architecture on big numbers' random generation
capt4ce
reviewed
Mar 23, 2021
p2p/strategy/priorityStrategy.go
Outdated
| idx := 0 | ||
| for _, peer := range unresolvedPeers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
p2p/strategy/priorityStrategy.go
Outdated
Comment on lines
1314
to
1316
| idx := 0 | ||
| for _, peer := range knownPeers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
p2p/strategy/peerStrategyHelper.go
Outdated
Comment on lines
81
to
83
| idx := 0 | ||
| for _, knownPeer := range peers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
p2p/strategy/nativeStrategy.go
Outdated
Comment on lines
497
to
499
| idx := 0 | ||
| for _, peer := range knownPeers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
p2p/strategy/nativeStrategy.go
Outdated
Comment on lines
369
to
371
| idx := 0 | ||
| for _, peer := range unresolvedPeers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
p2p/strategy/nativeStrategy.go
Outdated
Comment on lines
312
to
314
| idx := 0 | ||
| for _, peer := range resolvedPeers { | ||
| if idx == randomIdx { | ||
| if uint64(idx) == randomIdx { |
There was a problem hiding this comment.
I think this casting should better be performed when we initiate idx := 0 right?
* Fix issue with 32bit architecture on big numbers' random generation
capt4ce
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with 32bit architecture on big numbers' random generation