Fix issue with 32bit architecture on big numbers' random generation (#1494)

* Fix issue with 32bit architecture on big numbers' random generation

Co-authored-by: stefano galassi <stefano.galassi@blockchainzoo.com>

Author: iltoga

core/blockchainsync/downloadBlockchain.go

@@ -316,7 +316,7 @@ func (bd *BlockchainDownloader) DownloadFromPeer(feederPeer *model.Peer, chainBl
 	}
 
 	monitoring.IncrementMainchainDownloadCycleDebugger(bd.ChainType, 51)
-	initialPeerIdx := int(commonUtil.GetSecurePositiveRandom()) % len(peersSlice)
+	initialPeerIdx := uint64(commonUtil.GetSecurePositiveRandom()) % uint64(len(peersSlice))
 	nextPeerIdx := initialPeerIdx
 	peerUsed := feederPeer
 	blocksSegments := [][]*model.Block{}
@@ -326,7 +326,7 @@ func (bd *BlockchainDownloader) DownloadFromPeer(feederPeer *model.Peer, chainBl
 		if start != uint32(0) {
 			peerUsed = peersSlice[nextPeerIdx]
 			nextPeerIdx++
-			if nextPeerIdx >= len(peersSlice) {
+			if nextPeerIdx >= uint64(len(peersSlice)) {
 				nextPeerIdx = 0
 			}
 			if nextPeerIdx == initialPeerIdx {

p2p/strategy/nativeStrategy.go

@@ -305,11 +305,11 @@ func (ns *NativeStrategy) GetAnyResolvedPeer() *model.Peer {
 	if len(resolvedPeers) < 1 {
 		return nil
 	}
-	randomIdx := int(util.GetSecurePositiveRandom())
+	randomIdx := uint64(util.GetSecurePositiveRandom())
 	if randomIdx != 0 {
-		randomIdx %= len(resolvedPeers)
+		randomIdx %= uint64(len(resolvedPeers))
 	}
-	idx := 0
+	var idx uint64
 	for _, peer := range resolvedPeers {
 		if idx == randomIdx {
 			return peer
@@ -365,8 +365,8 @@ func (ns *NativeStrategy) GetAnyUnresolvedPeer() *model.Peer {
 	if len(unresolvedPeers) < 1 {
 		return nil
 	}
-	randomIdx := int(util.GetSecurePositiveRandom()) % len(unresolvedPeers)
-	idx := 0
+	randomIdx := uint64(util.GetSecurePositiveRandom()) % uint64(len(unresolvedPeers))
+	var idx uint64
 	for _, peer := range unresolvedPeers {
 		if idx == randomIdx {
 			return peer
@@ -493,8 +493,8 @@ func (ns *NativeStrategy) GetAnyKnownPeer() *model.Peer {
 	if len(knownPeers) < 1 {
 		panic("No well known peer is found")
 	}
-	randomIdx := int(util.GetSecurePositiveRandom()) % len(knownPeers)
-	idx := 0
+	randomIdx := uint64(util.GetSecurePositiveRandom()) % uint64(len(knownPeers))
+	var idx uint64
 	for _, peer := range knownPeers {
 		if idx == randomIdx {
 			return peer

p2p/strategy/peerStrategyHelper.go

@@ -76,9 +76,9 @@ func NewPeerStrategyHelper() *PeerStrategyHelper {
 func (ps *PeerStrategyHelper) GetRandomPeerWithoutRepetition(peers map[string]*model.Peer, mutex *sync.Mutex) *model.Peer {
 	var (
 		peer *model.Peer
+		idx  uint64
 	)
-	randomIdx := int(util.GetSecurePositiveRandom()) % len(peers)
-	idx := 0
+	randomIdx := uint64(util.GetSecurePositiveRandom()) % uint64(len(peers))
 	for _, knownPeer := range peers {
 		if idx == randomIdx {
 			peer = knownPeer

p2p/strategy/priorityStrategy.go

@@ -968,11 +968,11 @@ func (ps *PriorityStrategy) GetAnyResolvedPeer() *model.Peer {
 	if lengthResolvoedPeers < 1 {
 		return nil
 	}
-	randomIdx := int(util.GetSecurePositiveRandom())
+	randomIdx := uint64(util.GetSecurePositiveRandom())
 	if randomIdx != 0 {
-		randomIdx %= lengthResolvoedPeers
+		randomIdx %= uint64(lengthResolvoedPeers)
 	}
-	idx := 0
+	var idx uint64
 	for _, peer := range ps.NodeConfigurationService.GetHost().ResolvedPeers {
 		if idx == randomIdx {
 			return peer
@@ -1106,8 +1106,8 @@ func (ps *PriorityStrategy) GetAnyUnresolvedPeer() *model.Peer {
 	if len(unresolvedPeers) < 1 {
 		return nil
 	}
-	randomIdx := int(util.GetSecurePositiveRandom()) % len(unresolvedPeers)
-	idx := 0
+	randomIdx := uint64(util.GetSecurePositiveRandom()) % uint64(len(unresolvedPeers))
+	var idx uint64
 	for _, peer := range unresolvedPeers {
 		if idx == randomIdx {
 			return peer
@@ -1310,8 +1310,8 @@ func (ps *PriorityStrategy) GetAnyKnownPeer() *model.Peer {
 	if len(knownPeers) < 1 {
 		panic("No well known peer is found")
 	}
-	randomIdx := int(util.GetSecurePositiveRandom()) % len(knownPeers)
-	idx := 0
+	randomIdx := uint64(util.GetSecurePositiveRandom()) % uint64(len(knownPeers))
+	var idx uint64
 	for _, peer := range knownPeers {
 		if idx == randomIdx {
 			return peer