Skip to content

Updates for the usage of Zonemaster::Engine::Translator #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgreenx merged 1 commit into from
May 15, 2023
Merged

Updates for the usage of Zonemaster::Engine::Translator #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Zonemaster/Engine/Test/Address.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
ADDRESS01 => sub {
__x # ADDRESS:ADDRESS01
'Name server address must be globally routable', @_;
'Name server address must be globally routable';
},
ADDRESS02 => sub {
__x # ADDRESS:ADDRESS02
'Reverse DNS entry exists for name server IP address', @_;
'Reverse DNS entry exists for name server IP address';
},
ADDRESS03 => sub {
__x # ADDRESS:ADDRESS03
'Reverse DNS entry matches name server name', @_;
'Reverse DNS entry matches name server name';
},
NAMESERVER_IP_WITHOUT_REVERSE => sub {
__x # ADDRESS:NAMESERVER_IP_WITHOUT_REVERSE
Expand Down
8 changes: 4 additions & 4 deletions lib/Zonemaster/Engine/Test/Basic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,19 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
BASIC00 => sub {
__x # BASIC:BASIC00
'Domain name must be valid', @_;
'Domain name must be valid';
},
BASIC01 => sub {
__x # BASIC:BASIC01
'The domain must have a parent domain', @_;
'The domain must have a parent domain';
},
BASIC02 => sub {
__x # BASIC:BASIC02
'The domain must have at least one working name server', @_;
'The domain must have at least one working name server';
},
BASIC03 => sub {
__x # BASIC:BASIC03
'The Broken but functional test', @_;
'The Broken but functional test';
},
A_QUERY_NO_RESPONSES => sub {
__x # BASIC:A_QUERY_NO_RESPONSES
Expand Down
10 changes: 4 additions & 6 deletions lib/Zonemaster/Engine/Test/Connectivity.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,21 +127,20 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
CONNECTIVITY01 => sub {
__x # CONNECTIVITY:CONNECTIVITY01
'UDP connectivity', @_;
'UDP connectivity';
},
CONNECTIVITY02 => sub {
__x # CONNECTIVITY:CONNECTIVITY02
'TCP connectivity', @_;
'TCP connectivity';
},
CONNECTIVITY03 => sub {
__x # CONNECTIVITY:CONNECTIVITY03
'AS Diversity', @_;
'AS Diversity';
},
CONNECTIVITY04 => sub {
__x # CONNECTIVITY:CONNECTIVITY04
'IP Prefix Diversity', @_;
'IP Prefix Diversity';
},

CN01_IPV4_DISABLED => sub {
__x # CONNECTIVITY:CN01_IPV4_DISABLED
'IPv4 is disabled. No DNS queries are sent to these name servers: "{ns_list}".', @_;
Expand Down Expand Up @@ -332,7 +331,6 @@ Readonly my %TAG_DESCRIPTIONS => (
__x # CONNECTIVITY:ASN_INFOS_ANNOUNCE_IN
'Name server IP address "{ns_ip}" is announced in prefix "{prefix}".', @_;
},

TEST_CASE_END => sub {
__x # CONNECTIVITY:TEST_CASE_END
'TEST_CASE_END {testcase}.', @_;
Expand Down
12 changes: 6 additions & 6 deletions lib/Zonemaster/Engine/Test/Consistency.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,27 +138,27 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
CONSISTENCY01 => sub {
__x # CONSISTENCY:CONSISTENCY01
'SOA serial number consistency', @_;
'SOA serial number consistency';
},
CONSISTENCY02 => sub {
__x # CONSISTENCY:CONSISTENCY02
'SOA RNAME consistency', @_;
'SOA RNAME consistency';
},
CONSISTENCY03 => sub {
__x # CONSISTENCY:CONSISTENCY03
'SOA timers consistency', @_;
'SOA timers consistency';
},
CONSISTENCY04 => sub {
__x # CONSISTENCY:CONSISTENCY04
'Name server NS consistency', @_;
'Name server NS consistency';
},
CONSISTENCY05 => sub {
__x # CONSISTENCY:CONSISTENCY05
'Consistency between glue and authoritative data', @_;
'Consistency between glue and authoritative data';
},
CONSISTENCY06 => sub {
__x # CONSISTENCY:CONSISTENCY06
'SOA MNAME consistency', @_;
'SOA MNAME consistency';
},
ADDRESSES_MATCH => sub {
__x # CONSISTENCY:ADDRESSES_MATCH
Expand Down
36 changes: 18 additions & 18 deletions lib/Zonemaster/Engine/Test/DNSSEC.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,75 +515,75 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
DNSSEC01 => sub {
__x # DNSSEC:DNSSEC01
"Legal values for the DS hash digest algorithm", @_;
"Legal values for the DS hash digest algorithm";
},
DNSSEC02 => sub {
__x # DNSSEC:DNSSEC02
"DS must match a valid DNSKEY in the child zone", @_;
"DS must match a valid DNSKEY in the child zone";
},
DNSSEC03 => sub {
__x # DNSSEC:DNSSEC03
"Check for too many NSEC3 iterations", @_;
"Check for too many NSEC3 iterations";
},
DNSSEC04 => sub {
__x # DNSSEC:DNSSEC04
"Check for too short or too long RRSIG lifetimes", @_;
"Check for too short or too long RRSIG lifetimes";
},
DNSSEC05 => sub {
__x # DNSSEC:DNSSEC05
"Check for invalid DNSKEY algorithms", @_;
"Check for invalid DNSKEY algorithms";
},
DNSSEC06 => sub {
__x # DNSSEC:DNSSEC06
"Verify DNSSEC additional processing", @_;
"Verify DNSSEC additional processing";
},
DNSSEC07 => sub {
__x # DNSSEC:DNSSEC07
"If DNSKEY at child, parent should have DS", @_;
"If DNSKEY at child, parent should have DS";
},
DNSSEC08 => sub {
__x # DNSSEC:DNSSEC08
"Valid RRSIG for DNSKEY", @_;
"Valid RRSIG for DNSKEY";
},
DNSSEC09 => sub {
__x # DNSSEC:DNSSEC09
"RRSIG(SOA) must be valid and created by a valid DNSKEY", @_;
"RRSIG(SOA) must be valid and created by a valid DNSKEY";
},
DNSSEC10 => sub {
__x # DNSSEC:DNSSEC10
"Zone contains NSEC or NSEC3 records", @_;
"Zone contains NSEC or NSEC3 records";
},
DNSSEC11 => sub {
__x # DNSSEC:DNSSEC11
"DS in delegation requires signed zone", @_;
"DS in delegation requires signed zone";
},
DNSSEC12 => sub {
__x # DNSSEC:DNSSEC12
"Test for DNSSEC Algorithm Completeness", @_;
"Test for DNSSEC Algorithm Completeness";
},
DNSSEC13 => sub {
__x # DNSSEC:DNSSEC13
"All DNSKEY algorithms used to sign the zone", @_;
"All DNSKEY algorithms used to sign the zone";
},
DNSSEC14 => sub {
__x # DNSSEC:DNSSEC14
"Check for valid RSA DNSKEY key size", @_;
"Check for valid RSA DNSKEY key size";
},
DNSSEC15 => sub {
__x # DNSSEC:DNSSEC15
"Existence of CDS and CDNSKEY", @_;
"Existence of CDS and CDNSKEY";
},
DNSSEC16 => sub {
__x # DNSSEC:DNSSEC16
"Validate CDS", @_;
"Validate CDS";
},
DNSSEC17 => sub {
__x # DNSSEC:DNSSEC17
"Validate CDNSKEY", @_;
"Validate CDNSKEY";
},
DNSSEC18 => sub {
__x # DNSSEC:DNSSEC18
"Validate trust from DS to CDS and CDNSKEY ", @_;
"Validate trust from DS to CDS and CDNSKEY";
},
ADDITIONAL_DNSKEY_SKIPPED => sub {
__x # DNSSEC:ADDITIONAL_DNSKEY_SKIPPED
Expand Down
14 changes: 7 additions & 7 deletions lib/Zonemaster/Engine/Test/Delegation.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,31 +136,31 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
DELEGATION01 => sub {
__x # DELEGATION:DELEGATION01
"Minimum number of name servers", @_;
"Minimum number of name servers";
},
DELEGATION02 => sub {
__x # DELEGATION:DELEGATION02
"Name servers must have distinct IP addresses", @_;
"Name servers must have distinct IP addresses";
},
DELEGATION03 => sub {
__x # DELEGATION:DELEGATION03
"No truncation of referrals", @_;
"No truncation of referrals";
},
DELEGATION04 => sub {
__x # DELEGATION:DELEGATION04
"Name server is authoritative", @_;
"Name server is authoritative";
},
DELEGATION05 => sub {
__x # DELEGATION:DELEGATION05
"Name server must not point at CNAME alias", @_;
"Name server must not point at CNAME alias";
},
DELEGATION06 => sub {
__x # DELEGATION:DELEGATION06
"Existence of SOA", @_;
"Existence of SOA";
},
DELEGATION07 => sub {
__x # DELEGATION:DELEGATION07
"Parent glue name records present in child", @_;
"Parent glue name records present in child";
},
ARE_AUTHORITATIVE => sub {
__x # DELEGATION:ARE_AUTHORITATIVE
Expand Down
30 changes: 15 additions & 15 deletions lib/Zonemaster/Engine/Test/Nameserver.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,63 +233,63 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
NAMESERVER01 => sub {
__x # NAMESERVER:NAMESERVER01
'A name server should not be a recursor', @_;
'A name server should not be a recursor';
},
NAMESERVER02 => sub {
__x # NAMESERVER:NAMESERVER02
'Test of EDNS0 support', @_;
'Test of EDNS0 support';
},
NAMESERVER03 => sub {
__x # NAMESERVER:NAMESERVER03
'Test availability of zone transfer (AXFR)', @_;
'Test availability of zone transfer (AXFR)';
},
NAMESERVER04 => sub {
__x # NAMESERVER:NAMESERVER04
'Same source address', @_;
'Same source address';
},
NAMESERVER05 => sub {
__x # NAMESERVER:NAMESERVER05
'Behaviour against AAAA query', @_;
'Behaviour against AAAA query';
},
NAMESERVER06 => sub {
__x # NAMESERVER:NAMESERVER06
'NS can be resolved', @_;
'NS can be resolved';
},
NAMESERVER07 => sub {
__x # NAMESERVER:NAMESERVER07
'To check whether authoritative name servers return an upward referral', @_;
'To check whether authoritative name servers return an upward referral';
},
NAMESERVER08 => sub {
__x # NAMESERVER:NAMESERVER08
'Testing QNAME case insensitivity', @_;
'Testing QNAME case insensitivity';
},
NAMESERVER09 => sub {
__x # NAMESERVER:NAMESERVER09
'Testing QNAME case sensitivity', @_;
'Testing QNAME case sensitivity';
},
NAMESERVER10 => sub {
__x # NAMESERVER:NAMESERVER10
'Test for undefined EDNS version', @_;
'Test for undefined EDNS version';
},
NAMESERVER11 => sub {
__x # NAMESERVER:NAMESERVER11
'Test for unknown EDNS OPTION-CODE', @_;
'Test for unknown EDNS OPTION-CODE';
},
NAMESERVER12 => sub {
__x # NAMESERVER:NAMESERVER12
'Test for unknown EDNS flags', @_;
'Test for unknown EDNS flags';
},
NAMESERVER13 => sub {
__x # NAMESERVER:NAMESERVER13
'Test for truncated response on EDNS query', @_;
'Test for truncated response on EDNS query';
},
NAMESERVER14 => sub {
__x # NAMESERVER:NAMESERVER14
'Test for unknown version with unknown OPTION-CODE', @_;
'Test for unknown version with unknown OPTION-CODE';
},
NAMESERVER15 => sub {
__x # NAMESERVER:NAMESERVER15
'Checking for revealed software version', @_;
'Checking for revealed software version';
},
AAAA_BAD_RDATA => sub {
__x # NAMESERVER:AAAA_BAD_RDATA
Expand Down
16 changes: 8 additions & 8 deletions lib/Zonemaster/Engine/Test/Syntax.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,35 +151,35 @@ sub metadata {
Readonly my %TAG_DESCRIPTIONS => (
SYNTAX01 => sub {
__x # SYNTAX:SYNTAX01
'No illegal characters in the domain name', @_;
'No illegal characters in the domain name';
},
SYNTAX02 => sub {
__x # SYNTAX:SYNTAX02
'No hyphen (\'-\') at the start or end of the domain name', @_;
'No hyphen (\'-\') at the start or end of the domain name';
},
SYNTAX03 => sub {
__x # SYNTAX:SYNTAX03
'There must be no double hyphen (\'--\') in position 3 and 4 of the domain name', @_;
'There must be no double hyphen (\'--\') in position 3 and 4 of the domain name';
},
SYNTAX04 => sub {
__x # SYNTAX:SYNTAX04
'The NS name must have a valid domain/hostname', @_;
'The NS name must have a valid domain/hostname';
},
SYNTAX05 => sub {
__x # SYNTAX:SYNTAX05
'Misuse of \'@\' character in the SOA RNAME field', @_;
'Misuse of \'@\' character in the SOA RNAME field';
},
SYNTAX06 => sub {
__x # SYNTAX:SYNTAX06
'No illegal characters in the SOA RNAME field', @_;
'No illegal characters in the SOA RNAME field';
},
SYNTAX07 => sub {
__x # SYNTAX:SYNTAX07
'No illegal characters in the SOA MNAME field', @_;
'No illegal characters in the SOA MNAME field';
},
SYNTAX08 => sub {
__x # SYNTAX:SYNTAX08
'MX name must have a valid hostname', @_;
'MX name must have a valid hostname';
},
DISCOURAGED_DOUBLE_DASH => sub {
__x # SYNTAX:DISCOURAGED_DOUBLE_DASH
Expand Down
Loading