Updates for the usage of Zonemaster::Engine::Translator#1221
Merged
tgreenx merged 1 commit intozonemaster:developfrom May 15, 2023
Merged
Updates for the usage of Zonemaster::Engine::Translator#1221tgreenx merged 1 commit intozonemaster:developfrom
tgreenx merged 1 commit intozonemaster:developfrom
Conversation
tgreenx
added
A-Translation
tgreenx
requested review from
a user,
hannaeko,
marc-vanderwal,
matsduf and
mattias-p
matsduf
previously approved these changes
May 12, 2023
Contributor
marc-vanderwal
left a comment
marc-vanderwal
left a comment
There was a problem hiding this comment.
I saw just one teeny tiny typo.
- Update documentation in Zonemaster::Engine::Translator - Update unitary tests in t/translator.t to check that a message tag exists for each implemented Test Case - Remove useless parameter in Test Case ID message tags in each Test Case module
tgreenx
force-pushed
the
update-translator-testing
branch
from
cc072f4 to
12431bb
Compare
Contributor
Author
|
@matsduf @marc-vanderwal please re-approve |
marc-vanderwal
approved these changes
May 15, 2023
Contributor
|
Unit tests are passing, translation of test case is working. |
hannaeko
added
the
S-ReleaseTested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR proposes updates to the usage of Zonemaster::Engine::Translator. It updates its documentation, adds unitary tests, and harmonizes message tags in each Test Case modules.
Context
#1144 mentions missing unitary tests and unneeded parameters.
Changes
lib/Zonemaster/Engine/Translator.pmt/translator.tlib/Zonemaster/Engine/Test/[ Address ... Zone ].pmHow to test this PR
Tests should pass.