Make --stop-level disabled by default again#395
Merged
mattias-p merged 1 commit intozonemaster:developfrom Nov 14, 2024
Merged
Conversation
mattias-p
added
the
V-Minor
mattias-p
requested review from
MichaelTimbert,
marc-vanderwal,
matsduf,
tgreenx and
tolvmannen
mattias-p
force-pushed
the
394-stop-level
branch
from
352f915 to
2ad101e
Compare
mattias-p
changed the title
Merged
mattias-p
force-pushed
the
394-stop-level
branch
from
2ad101e to
9c4ca50
Compare
Disabled is now represented as the empty string.
mattias-p
force-pushed
the
394-stop-level
branch
from
9c4ca50 to
fbaac8b
Compare
matsduf
approved these changes
Nov 14, 2024
Contributor
|
Release testing for 2024.2: all unit tests pass on current |
marc-vanderwal
added
the
S-ReleaseTested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes zonemaster-cli only stop testing early if --stop-level is set, making it easier to develop Zonemaster test cases again.
Context
Fixes #394.
Changes
--opt=is enabled. This makes it easier to reset--stop-levelto its default value after it has been set to something else (e.g.--stop-level=error). Since--opt=was outright rejected before, this is not a breaking change, but it is a new feature.Testing