-
Notifications
You must be signed in to change notification settings - Fork 22
Closed
Labels
T-BugType: Bug in software or error in test case descriptionType: Bug in software or error in test case description
Milestone
Description
When Engine emits a CRITICAL message, CLI used to continue testing unless --stop-level has been explicitly set, resulting in output like this:
$ zonemaster-cli --no-ipv6 --no-time --raw mail.protection.outlook.comCRITICAL B02_NO_WORKING_NS domain="mail.protection.outlook.com"
ERROR B02_UNEXPECTED_RCODE ns=ns2-proddns.glbdns.protection.outlook.com/104.47.72.81; rcode=FORMERR
ERROR B02_UNEXPECTED_RCODE ns=ns1-proddns.glbdns.protection.outlook.com/104.47.34.49; rcode=FORMERR
CRITICAL CANNOT_CONTINUE domain=mail.protection.outlook.com
However #371 inadvertently changed this behavior so that test case execution terminates immediately if a CRITICAL message is emitted.
CRITICAL B02_NO_WORKING_NS domain="mail.protection.outlook.com"
Exited early: Saw message at level CRITICAL
The new behavior makes it harder to develop test cases that emit CRITICAL messages.
This was first reported in the PR thread of #389.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
T-BugType: Bug in software or error in test case descriptionType: Bug in software or error in test case description