Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump msrv to 1.64.0 #116

Closed
wants to merge 1 commit into from
Closed

bump msrv to 1.64.0 #116

wants to merge 1 commit into from

Conversation

tcoratger
Copy link

A bump of MSRV is done to fix:

error: package `rayon-core v1.12.0` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.56.0

rustc 1.63 has a problem with compilation that's why this is directly bumped to 1.64.0

@str4d
Copy link
Member

str4d commented Jul 21, 2024

MSRV 1.56 does work, if you use rayon-core 1.10. We now have Cargo.lock checked in and CI jobs to ensure that tests pass on an MSRV-compatible set of dependencies, as well as latest dependencies with stable Rust. So this breakage will no longer occur when making PRs on this repo, and this MSRV bump is not necessary.

There might be other reasons we want to bump MSRV, but those should be discussed in a separate issue.

@str4d str4d closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants