Skip to content

Tests can't compile due to rayon MSRV update without new minor bump #112

Closed
@CPerezz

Description

If you try to run the tests for this lib, you'll see that you get:

error: package rayon-core v1.11.0 cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.56.0

This is due to the fact that:

❯ cargo tree -i rayon-core       
rayon-core v1.11.0
└── rayon v1.7.0
    └── criterion v0.3.6
        [dev-dependencies]
        └── bls12_381 v0.8.0 

As you can see here, criterion depends on rayon_core with ^0.3. After rayon moved up MSRV without bumping minor version, everything broke.

We might want to either:

  • Bump MSRV.
  • Fix Cargo.lock (doesn't make any sense to me as this is a lib).
  • Downgrade Criterion in hopes it uses a version of rayon compatible with rustc 1.56.0 or older.

@str4d let me know what you prefer and I'll push a PR.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions