migrate DEFAULT_SERVER into config #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannasessha
reviewed
Jun 23, 2022
Contributor
dannasessha
left a comment
dannasessha
left a comment
There was a problem hiding this comment.
Looks pretty good!
I'm going to build locally and check out a little more of the "wiring" before merging, but should happen shortly.
Member
Author
|
So, if you approve this code, can you please merge it @dannasessha ? |
Contributor
|
Built locally for me, and worked, but I had to move aside There were some warnings associated with the build, but I think that is understood and we're moving fast, we'll circle back to those. I am going to merge in. |
dannasessha
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.