Merge pull request #1 from zancas/dev_poc_tests

Dev poc tests

Author: idky137

integration-tests/tests/integrations.rs

@@ -1001,7 +1001,7 @@ mod slow {
         let wallet_capability = original_recipient.wallet.wallet_capability().clone();
         let [o_fvk, s_fvk, t_fvk] =
             zingo_testutils::build_fvks_from_wallet_capability(&wallet_capability);
-        let fvks_sets = vec![
+        let fvks_sets = [
             vec![&o_fvk],
             vec![&s_fvk],
             vec![&o_fvk, &s_fvk],
@@ -3462,7 +3462,7 @@ mod slow {
                     .unwrap(),
             )
             .create();
-        let wallet = LightWallet::read_internal(&data[..], &config)
+        let wallet = LightWallet::read_internal(data, &config)
             .await
             .map_err(|e| format!("Cannot deserialize LightWallet file!: {}", e))
             .unwrap();

zingolib/src/blaze/test_utils.rs

@@ -24,11 +24,11 @@ pub fn trees_from_cblocks(
     for fake_compact_block in compactblock_list {
         let mut sapling_tree = sapling_trees
             .last()
-            .map(Clone::clone)
+            .cloned()
             .unwrap_or_else(CommitmentTree::empty);
         let mut orchard_tree = orchard_trees
             .last()
-            .map(Clone::clone)
+            .cloned()
             .unwrap_or_else(CommitmentTree::empty);
         for compact_transaction in &fake_compact_block.block.vtx {
             update_trees_with_compact_transaction(

zingolib/src/commands/utils.rs

@@ -214,7 +214,7 @@ mod tests {
                             e,
                             format!(
                                 "Error creating output. Memo '\"{}\"' is too long",
-                                long_513_byte_memo.to_string()
+                                long_513_byte_memo
                             )
                         )
                     }
@@ -256,7 +256,7 @@ mod tests {
                             e,
                             format!(
                                 "Error creating output. Memo '\"{}\"' is too long",
-                                long_513_byte_memo.to_string()
+                                long_513_byte_memo
                             )
                         )
                     }

zingolib/src/wallet/send.rs

@@ -868,15 +868,14 @@ mod tests {
     fn test_build_request() {
         let amount_1 = NonNegativeAmount::const_from_u64(20000);
         let recipient_address_1 =
-            Address::decode(&ChainType::Testnet, &"utest17wwv8nuvdnpjsxtu6ndz6grys5x8wphcwtzmg75wkx607c7cue9qz5kfraqzc7k9dfscmylazj4nkwazjj26s9rhyjxm0dcqm837ykgh2suv0at9eegndh3kvtfjwp3hhhcgk55y9d2ys56zkw8aaamcrv9cy0alj0ndvd0wll4gxhrk9y4yy9q9yg8yssrencl63uznqnkv7mk3w05".to_string()).unwrap();
+            Address::decode(&ChainType::Testnet, "utest17wwv8nuvdnpjsxtu6ndz6grys5x8wphcwtzmg75wkx607c7cue9qz5kfraqzc7k9dfscmylazj4nkwazjj26s9rhyjxm0dcqm837ykgh2suv0at9eegndh3kvtfjwp3hhhcgk55y9d2ys56zkw8aaamcrv9cy0alj0ndvd0wll4gxhrk9y4yy9q9yg8yssrencl63uznqnkv7mk3w05").unwrap();
         let memo_1 = None;
 
         let amount_2 = NonNegativeAmount::const_from_u64(20000);
         let recipient_address_2 =
-            Address::decode(&ChainType::Testnet, &"utest17wwv8nuvdnpjsxtu6ndz6grys5x8wphcwtzmg75wkx607c7cue9qz5kfraqzc7k9dfscmylazj4nkwazjj26s9rhyjxm0dcqm837ykgh2suv0at9eegndh3kvtfjwp3hhhcgk55y9d2ys56zkw8aaamcrv9cy0alj0ndvd0wll4gxhrk9y4yy9q9yg8yssrencl63uznqnkv7mk3w05".to_string()).unwrap();
+            Address::decode(&ChainType::Testnet, "utest17wwv8nuvdnpjsxtu6ndz6grys5x8wphcwtzmg75wkx607c7cue9qz5kfraqzc7k9dfscmylazj4nkwazjj26s9rhyjxm0dcqm837ykgh2suv0at9eegndh3kvtfjwp3hhhcgk55y9d2ys56zkw8aaamcrv9cy0alj0ndvd0wll4gxhrk9y4yy9q9yg8yssrencl63uznqnkv7mk3w05").unwrap();
         let memo_2 = Some(MemoBytes::from(
-            Memo::from_str(&"the lake wavers along the beach".to_string())
-                .expect("string can memofy"),
+            Memo::from_str("the lake wavers along the beach").expect("string can memofy"),
         ));
 
         let rec: Receivers = vec![