Skip to content

link: Recognize -Wl,-implib,foo.lib and pass it to LLD as /implib:foo.lib. #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

link: Recognize -Wl,-implib,foo.lib and pass it to LLD as /implib:foo.lib. #9251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/link/Coff.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,9 @@ fn linkWithLLD(self: *Coff, comp: *Compilation) !void {
if (self.base.options.dynamicbase) {
try argv.append("-dynamicbase");
}

try argv.appendSlice(self.base.options.extra_lld_args);

const subsystem_suffix = ss: {
if (self.base.options.major_subsystem_version) |major| {
if (self.base.options.minor_subsystem_version) |minor| {
Expand Down
6 changes: 6 additions & 0 deletions src/main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,6 +1341,12 @@ fn buildOutputType(
fatal("expected linker arg after '{s}'", .{arg});
}
version_script = linker_args.items[i];
} else if (mem.eql(u8, arg, "-implib")) {
i += 1;
if (i >= linker_args.items.len) {
fatal("expected linker arg after '{s}'", .{arg});
}
try lld_argv.append(try std.fmt.allocPrint(arena, "/implib:{s}", .{linker_args.items[i]}));
} else if (mem.startsWith(u8, arg, "-O")) {
try lld_argv.append(arg);
} else if (mem.eql(u8, arg, "--gc-sections")) {
Expand Down